Bump UI tests global timeout #2685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like some ui tests run slower in ci. It's random so maybe a resource thing. I noticed in the docs that there's a new beta feature that sets browser tests to have a 15s timeout. I dont want to use a beta feature so I'm just manually bumping the global timeout here to 15_000ms https://vitest.dev/config/#testtimeout https://vitest.dev/guide/browser/ Signed-off-by: fayi-da <fayimora.femibalogun@digitalasset.com>
Signed-off-by: fayi-da <fayimora.femibalogun@digitalasset.com>
fayi-da
force-pushed
the
fayi/bump-ui-tests-timeout
branch
from
7985253 to
435b2de
Compare
Signed-off-by: fayi-da <fayimora.femibalogun@digitalasset.com>
Signed-off-by: fayi-da <fayimora.femibalogun@digitalasset.com>
fayi-da
requested review from
OriolMunoz-da,
julientinguely-da,
pawelperek-da and
ray-roestenburg-da
ray-roestenburg-da
approved these changes
Oct 14, 2025
fayi-da
commented
Oct 14, 2025
| environment: 'happy-dom', | ||
| exclude: ['../lib/**'], | ||
| silent: false, | ||
| testTimeout: 15000, |
Contributor
Author
There was a problem hiding this comment.
Main change is here. The rest is just formatting and removing individual timeouts
| environment: 'happy-dom', | ||
| exclude: ['../lib/**'], | ||
| silent: false, | ||
| testTimeout: 15000, |
Contributor
There was a problem hiding this comment.
have you tried setting this to 1 and checking that all tests fail after a timeout? I once tried to change it and miserably failed, but might be due to commons needing rebuilding and such
Contributor
Author
There was a problem hiding this comment.
haha yeah that i'll be because of the 2 config files we have here. Almost caught me off guard too. The config in index is what we seem to be using so I'll create a tech debt to remove the other config(hopefully it's straightforward).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like some ui tests run slower in ci. It's random so maybe a resource thing. I noticed in the docs that there's a new beta feature that sets browser tests to have a 15s timeout. I don't want to use a beta feature so I'm just manually bumping the global timeout here to 15_000ms
https://vitest.dev/config/#testtimeout
https://vitest.dev/guide/browser/
Fixes https://github.com/DACH-NY/cn-test-failures/issues/5916
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines