CIP-82 (DAML/Docs): Default optDevelopmentFundPercentage to 0.05 + releases notes #3576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jose-velasco-ieu
changed the base branch from
main
to
josevelasco/feature-cip-82
jose-velasco-ieu
force-pushed
the
josevelasco/feature-cip-82
branch
from
21f3483 to
cfce301
Compare
…iningRound_StartIssuing in case is None (this avoid a one week rolling out) Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com>
jose-velasco-ieu
force-pushed
the
josevelasco/cip-82-release-notes-pr1-2
branch
from
d1caeb7 to
f3c7424
Compare
IssuanceConfig.optDevelopmentFundPercentage is set during SV1Initializer bootstrapping Set it to None if not supported; otherwise keep the existing value in sv1Config.developmentFundPercentage. Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com>
Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com>
jose-velasco-ieu
changed the title
meiersi-da
approved these changes
Jan 19, 2026
Contributor
meiersi-da
left a comment
meiersi-da
left a comment
There was a problem hiding this comment.
Thank you very much @jose-velasco-ieu ! Very nice work.
@pawelperek-da works on the new SV UI which requires adapting to also support the two new config values. @pawelperek-da can I ask you to help @jose-velasco-ieu with high priority to fix his PR to pass the “NEW UI: Set Amulet Rules Configuration” assertion that fails in his his CI run on this PR?
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Jose Velasco - IEU <jose.velasco@intellecteu.com>
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Jose Velasco - IEU <jose.velasco@intellecteu.com>
Contributor
|
@jose-velasco-ieu I've prepared a PR against the |
Contributor
Author
That's really good! Thank you @pawelperek-da |
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
pawelperek-da
approved these changes
Jan 19, 2026
jose-velasco-ieu
merged commit 21c947e
into
josevelasco/feature-cip-82
60 checks passed
jose-velasco-ieu
added a commit
that referenced
this pull request
Jan 19, 2026
…leases notes (#3576) - Default optDevelopmentFundPercentage to 0.05 in AmuletRules_MiningRound_StartIssuing in case when None. - Account for development fund support when optDevelopmentFundPercentage is set during SV1Initializer bootstrapping. - Add release note/ PR reviewed in #3576 CI run #3576 Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com>
Merged
6 tasks
jose-velasco-ieu
added a commit
that referenced
this pull request
Jan 19, 2026
…edDevelopmentFundCoupons (#3594) * Daml: Add support for DevelopmentFundCoupon PR reviewed in #3426 CI run #3451 Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com> * CIP-82 (Scala): Add MergeUnclaimedDevelopmentFundCouponsTrigger (#3522) PR reviewed in #3522 CI run #3522 Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com> * CIP-82 (DAML/Docs): Default optDevelopmentFundPercentage to 0.05 + releases notes (#3576) - Default optDevelopmentFundPercentage to 0.05 in AmuletRules_MiningRound_StartIssuing in case when None. - Account for development fund support when optDevelopmentFundPercentage is set during SV1Initializer bootstrapping. - Add release note/ PR reviewed in #3576 CI run #3576 Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com> * [ci] Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com> --------- Signed-off-by: Jose Velasco <jose.velasco@intellecteu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
optDevelopmentFundPercentageto 0.05 inAmuletRules_MiningRound_StartIssuingin case when None.optDevelopmentFundPercentageis set duringSV1Initializerbootstrapping. It is set it to None if not supported; otherwise keep the existing value in
sv1Config.developmentFundPercentage.Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines