Avoid stale button reference in SvFrontendIntegrationTest #3604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DACH-NY/cn-test-failures#6828 [ci] Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
| ) | ||
| val requestId = eventually() { | ||
| // find the review button again because the DOM may have been updated | ||
| val reviewButton = checkNewVoteRequestInProgressTab(previousVoteRequestsInProgress + 1) |
Contributor
There was a problem hiding this comment.
huh, I have a feeling that a function named checkNewVoteRequestInProgressTab probably shouldn't return the reviewButton but that's beyond the scope of this task 😛
Contributor
Author
There was a problem hiding this comment.
I tend to agree 🙈 Overall 1. when fixing a flake I just want to do it as quickly and with as few changes as possible and 2. every time I see a selenium test I wonder whether we shouldn't just kill it altogether in favor of vite + testing only the APIs 🙈 (Not saying that we should do it here, but it's my excuse for being less motivated on these tests...)
martinflorian-da
deleted the
martinflorian-da/cntf-6828-unflake-svfrontendtest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/DACH-NY/cn-test-failures/issues/6828
[ci]
Signed-off-by: Martin Florian martin.florian@digitalasset.com