Skip to content

Avoid stale button reference in SvFrontendIntegrationTest #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinflorian-da merged 1 commit into from
Jan 20, 2026
Merged

Avoid stale button reference in SvFrontendIntegrationTest #3604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...t/scala/org/lfdecentralizedtrust/splice/integration/tests/SvFrontendIntegrationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ class SvFrontendIntegrationTest
_ => checkNewVoteRequestInProgressTab(previousVoteRequestsInProgress),
)

val (_, reviewButton) = actAndCheck(
actAndCheck(
"sv1 operator creates a new vote request with a long expiration time", {
submitSetDsoConfigRequestViaFrontend(
numMemberTrafficContractsThreshold = "42"
Expand All @@ -1097,6 +1097,8 @@ class SvFrontendIntegrationTest
},
)
val requestId = eventually() {
// find the review button again because the DOM may have been updated
val reviewButton = checkNewVoteRequestInProgressTab(previousVoteRequestsInProgress + 1)
Copy link
Contributor

@pawelperek-da pawelperek-da Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, I have a feeling that a function named checkNewVoteRequestInProgressTab probably shouldn't return the reviewButton but that's beyond the scope of this task 😛

Copy link
Contributor Author

@martinflorian-da martinflorian-da Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree 🙈 Overall 1. when fixing a flake I just want to do it as quickly and with as few changes as possible and 2. every time I see a selenium test I wonder whether we shouldn't just kill it altogether in favor of vite + testing only the APIs 🙈 (Not saying that we should do it here, but it's my excuse for being less motivated on these tests...)

reviewButton.underlying.click()
val requestId =
inside(find(id("vote-request-modal-content-contract-id"))) { case Some(tb) =>
Expand Down
Loading