Fix cluster test instructions in TESTING.md #3663
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
TESTING.md
Outdated
| To request a cluster test to be run on your PR, comment on your pr `/cluster_test` or `/hdm_test` | ||
| for a basic test or a hard-migration test respectively. After commenting, reach out to the | ||
| [Splice Contributors](CONTRIBUTORS.md) to approve and trigger the actual test on your behalf. | ||
| for a basic test or a hard-migration test respectively. After commenting, you can self-approve and trigger the |
Contributor
There was a problem hiding this comment.
we need this to work for external contributors as well who cannot self-approve. So just mention that you should contact an existing maintainer without linking to anything and mention that within DA you cna self approve.
Contributor
Author
There was a problem hiding this comment.
Done. PTAL.
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
moritzkiefer-da
approved these changes
Jan 23, 2026
TESTING.md
Outdated
| for a basic test or a hard-migration test respectively. After commenting, reach out to the | ||
| [Splice Contributors](CONTRIBUTORS.md) to approve and trigger the actual test on your behalf. | ||
| for a basic test or a hard-migration test respectively. After commenting, you’ll need approval to trigger the test. | ||
| If you’re within DA, you can self-approve; otherwise, contact an existing maintainer to approve it. |
Contributor
There was a problem hiding this comment.
Suggested change
| If you’re within DA, you can self-approve; otherwise, contact an existing maintainer to approve it. | |
| If you're a Digital Asset employee, you can self-approve; otherwise, contact an existing maintainer to approve it. |
TESTING.md
Outdated
| To request a cluster test to be run on your PR, comment on your pr `/cluster_test` or `/hdm_test` | ||
| for a basic test or a hard-migration test respectively. After commenting, reach out to the | ||
| [Splice Contributors](CONTRIBUTORS.md) to approve and trigger the actual test on your behalf. | ||
| for a basic test or a hard-migration test respectively. After commenting, you’ll need approval to trigger the test. |
Contributor
There was a problem hiding this comment.
Suggested change
| for a basic test or a hard-migration test respectively. After commenting, you’ll need approval to trigger the test. | |
| for a basic test or a hard-migration test respectively. After commenting, the job needs to be approved to actually run. |
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
jagathweerasinghe-da
deleted the
wee/fix_cluster_test_instructions_in_TESTING.md
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[static]