Skip to content

Fix cluster test instructions in TESTING.md #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jagathweerasinghe-da merged 4 commits into from
Jan 23, 2026
+2 −2
Merged

Fix cluster test instructions in TESTING.md #3663

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84c59c8
rm invalid link and update cluster test instructions
jagathweerasinghe-da Jan 23, 2026
5d9b431
update test instructions
jagathweerasinghe-da Jan 23, 2026
e51e392
update test instructions
jagathweerasinghe-da Jan 23, 2026
9acf8cd
update test instructions
jagathweerasinghe-da Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TESTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ There are two types of cluster tests that can be requested on a PR:
- A Hard Migration test, which tests the full hard migration workflow on a scratch cluster.

To request a cluster test to be run on your PR, comment on your pr `/cluster_test` or `/hdm_test`
for a basic test or a hard-migration test respectively. After commenting, reach out to the
[Splice Contributors](CONTRIBUTORS.md) to approve and trigger the actual test on your behalf.
for a basic test or a hard-migration test respectively. After commenting, you’ll need approval to trigger the test.
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for a basic test or a hard-migration test respectively. After commenting, you’ll need approval to trigger the test.
for a basic test or a hard-migration test respectively. After commenting, the job needs to be approved to actually run.

Copy link
Contributor Author

@jagathweerasinghe-da jagathweerasinghe-da Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

If you’re within DA, you can self-approve; otherwise, contact an existing maintainer to approve it.
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you’re within DA, you can self-approve; otherwise, contact an existing maintainer to approve it.
If you're a Digital Asset employee, you can self-approve; otherwise, contact an existing maintainer to approve it.

Copy link
Contributor Author

@jagathweerasinghe-da jagathweerasinghe-da Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


### Enabling the new Canton bft ordering layer

Expand Down
Loading