actually enable async logging by default #3668
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
moritzkiefer-da
approved these changes
Jan 23, 2026
Contributor
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
thx, maybe worth mentioning in the release notes again?
| value: {{ .logLevelStdout | default "DEBUG" }} | ||
| - name: LOG_IMMEDIATE_FLUSH | ||
| value: {{ .logAsyncFlush | default false | not | quote }} | ||
| value: {{ .logAsyncFlush | default true | not | quote }} |
Contributor
There was a problem hiding this comment.
Shall we cover this with a Helm test so we don't regress accidentally? Seems easy to miss if we do. Might be a good-first-issue 🤷
Contributor
There was a problem hiding this comment.
Honestly I'm not sure you're testing anything useful here. It seems like getting the test correct is just as easy as getting the code correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[static]
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines