Skip to content

actually enable async logging by default #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicu-da merged 2 commits into from
Jan 23, 2026
+7 −1
Merged

actually enable async logging by default #3668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96c551c
actually enable async logging by default
nicu-da Jan 23, 2026
845a85a
.
nicu-da Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cluster/helm/splice-util-lib/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ spec:
- name: LOG_LEVEL_STDOUT
value: {{ .logLevelStdout | default "DEBUG" }}
- name: LOG_IMMEDIATE_FLUSH
value: {{ .logAsyncFlush | default false | not | quote }}
value: {{ .logAsyncFlush | default true | not | quote }}
Copy link
Contributor

@martinflorian-da martinflorian-da Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we cover this with a Helm test so we don't regress accidentally? Seems easy to miss if we do. Might be a good-first-issue 🤷

Copy link
Contributor

@moritzkiefer-da moritzkiefer-da Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'm not sure you're testing anything useful here. It seems like getting the test correct is just as easy as getting the code correct.

{{- end }}
{{- define "splice-util-lib.service-account" -}}
{{- if .serviceAccountName -}}
Expand Down
6 changes: 6 additions & 0 deletions docs/src/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@
- deprecated ``/v0/total-amulet-balance`` and ``/v0/wallet-balance`` endpoints have been removed in favor of using `/registry/metadata/v1/instruments/{instrumentId} <app_dev/token_standard/openapi/token_metadata.html#get--registry-metadata-v1-instruments-instrumentId>`_
and `/v0/holdings/summary <app_dev/scan_api/scan_openapi.html#post--v0-holdings-summary>`_, respectively.

- Deployments

- The default logger has been switched to use an asynchronous appender, for all the nodes, for better performance.
The behavior can be switched back to synchronous logging by setting the environment variable `LOG_IMMEDIATE_FLUSH=true`.
This now includes helm deployments as well, in 0.5.7 the default was changed only for docker-compose deployments.

.. release-notes:: 0.5.7

.. important::
Expand Down