8337 modify chain data pruner #8506

Matilda-Clerke · 2025-04-02T04:15:41Z

PR description

Add an online option to prune pre-merge blocks from the database

Fixed Issue(s)

#8337

Signed-off-by: Matilda Clerke <[email protected]>

…nesis block Signed-off-by: Matilda Clerke <[email protected]>

Signed-off-by: Matilda Clerke <[email protected]>

besu/src/main/java/org/hyperledger/besu/controller/BesuControllerBuilder.java

garyschulte · 2025-04-24T20:15:07Z

besu/src/main/java/org/hyperledger/besu/cli/options/ChainPruningOptions.java

+      names = {PRE_MERGE_PRUNING_ENABLED_FLAG},
+      description =
+          "Enable the chain pruner to actively prune pre-merge blocks, but not headers (default: ${DEFAULT-VALUE})")
+  private final Boolean preMergePruningEnabled = Boolean.FALSE;


it would be nice to see chain pruning be contingent on the sync mode in the same way trielog pruning is. Like a typical node would want to prune pre-merge history, but a full-sync node would not.

The network pre-merge cut-off could be an empty Optional for all networks except those that have at release time entered the proto-4444 window. This way chain pruning could always be enabled, but the presence or absence of a pruning cutoff is what causes the behavior change

While it would be nice to enable pruning by default, I think users might be upset by their stored history being deleted unexpectedly.

garyschulte

I was originally thinking of a one-off purge of pre-merge blocks and receipts but this approach makes sense in light of the future eip-4444 moving window

besu/src/main/java/org/hyperledger/besu/cli/options/ChainPruningOptions.java

pinges

Some comments

besu/src/main/java/org/hyperledger/besu/cli/options/ChainPruningOptions.java

besu/src/main/java/org/hyperledger/besu/controller/BesuControllerBuilder.java

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/ChainDataPruner.java

pinges · 2025-04-28T01:14:24Z

ethereum/core/src/test/java/org/hyperledger/besu/ethereum/chain/ChainDataPrunerTest.java

            new ChainDataPrunerStorage(new InMemoryKeyValueStorage()),
+            0,
+            ChainDataPruner.Mode.CHAIN_PRUNING,


No tests added for pre merge pruning?

Not yet, but I can add some once we're happy with the code

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]>

Signed-off-by: Matilda Clerke <[email protected]>

besu/src/main/java/org/hyperledger/besu/controller/BesuControllerBuilder.java

jflo · 2025-04-24T20:36:24Z

besu/src/main/java/org/hyperledger/besu/controller/BesuControllerBuilder.java

+              blockchainStorage, () -> blockchain.removeObserver(chainDataPrunerObserverId.get()));
+      chainDataPrunerObserverId.set(blockchain.observeBlockAdded(chainDataPruner));
+      if (chainPrunerConfiguration.chainPruningEnabled()) {
+        LOG.info(


Good user feedback.

jflo · 2025-04-24T20:40:31Z

besu/src/main/java/org/hyperledger/besu/controller/BesuControllerBuilder.java

+        switch (network) {
+          case MAINNET -> MAINNET_MERGE_BLOCK_NUMBER;
+          case SEPOLIA -> SEPOLIA_MERGE_BLOCK_NUMBER;
+          default -> 0;


If a network is cancun at genesis, like hoodi is, then we don't do any PRE_MERGE_PRUNING, which makes sense. We would start CHAIN_PRUNING once we got to block 256. However, 6110 doesn't activate till pectra does. Might we have an inconsistency wrt deposits in the interim between them?

I also prefer using the checkpoint at Genesis for pruning configuration, as it aligns with the approach taken in #8582

Gabriel-Trintinalia

I believe this PR shares some similarities with #8582.

The 8582 PR includes a flag for saving only headers to the database, which we could consolidate with the flags in this PR.

Additionally, 8582 utilises the checkpoint at genesis to establish the header cutoff. I suggest we adopt the same approach here, rather than introducing new constants to NetworkName or other locations.

Signed-off-by: Matilda Clerke <[email protected]>

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

...perledger/besu/plugin/services/storage/rocksdb/segmented/RocksDBColumnarKeyValueStorage.java

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/ChainDataPruner.java

ahamlat

This is not part of the PR, but more an improvement, make the chain pruner threadpool expose the same metrics names as other thread pools.
To include the metrics in Besu Full dashboard, we need to change

MonitoredExecutors.newBoundedThreadPool(
    ChainDataPruner.class.getSimpleName(),
    1,
    1,
    ChainDataPruner.MAX_PRUNING_THREAD_QUEUE_SIZE,
    metricsSystem));

to

MonitoredExecutors.newBoundedThreadPool(
            EthScheduler.class.getSimpleName() + "-ChainDataPruner",
            1,
            1,
            ChainDataPruner.MAX_PRUNING_THREAD_QUEUE_SIZE,
            metricsSystem));

One other solution is to integrate the thread pool to EthScheduler.
This is related to the formula we're using to display the metrics of monitred thread pools

as the formula currently is something like this
/besu_executors_ethscheduler_([^_]*)_.*/

Signed-off-by: Matilda Clerke <[email protected]>

…led status Signed-off-by: Matilda Clerke <[email protected]>

Signed-off-by: Matilda Clerke <[email protected]>

        EthScheduler.class.getSimpleName() + "-ChainDataPruner",

this change has been made

Signed-off-by: Matilda Clerke <[email protected]>

macfarla

needs a changelog

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/ChainDataPruner.java

besu/src/main/java/org/hyperledger/besu/cli/options/ChainPruningOptions.java

Matilda-Clerke · 2025-05-23T04:09:58Z

Latest testing, including enabling database garbage collection, shows fairly minimal impact on newPayload and FCU

Signed-off-by: Matilda Clerke <[email protected]>

…iple calls per expected call Signed-off-by: Matilda Clerke <[email protected]>

Signed-off-by: Matilda Clerke <[email protected]>

… of multiple calls per expected call" This reverts commit c197b1e. Signed-off-by: Matilda Clerke <[email protected]>

Signed-off-by: Matilda Clerke <[email protected]>

…kName Signed-off-by: Matilda Clerke <[email protected]>

…nto 8337-modify-chain-data-pruner

Matilda-Clerke · 2025-05-28T22:38:05Z

Some interesting findings from the latest test run (with double execution issue fixed)

All batch sizes eventually cause some increase in newPayload execution time above baseline, but lower batch size causes it to be less impactful over a longer period of time.

Signed-off-by: Matilda Clerke <[email protected]>

…nto 8337-modify-chain-data-pruner

siladu

LGTM 🚢

Matilda-Clerke added 3 commits April 1, 2025 14:42

Add pre-merge pruning options to ChainPruningOptions

daecbb7

Signed-off-by: Matilda Clerke <[email protected]>

Implement pre-merge block pruning in ChainDataPruner

749fe64

Signed-off-by: Matilda Clerke <[email protected]>

Add an info log to preMergePruningAction

388f631

Signed-off-by: Matilda Clerke <[email protected]>

Matilda-Clerke mentioned this pull request Apr 2, 2025

Online option to drop pre merge blocks #8493

Closed

Matilda-Clerke added 6 commits April 3, 2025 15:51

Add logging

eed10b3

Signed-off-by: Matilda Clerke <[email protected]>

Fix database setup

5d893b5

Signed-off-by: Matilda Clerke <[email protected]>

Unsubscribe after finishing pruning

5b12159

Signed-off-by: Matilda Clerke <[email protected]>

Enable garbage collection of blobs in static data segments

1931d3f

Signed-off-by: Matilda Clerke <[email protected]>

Change start of pre-merge block tuning from 0 to 1 to preserve the ge…

17c8c16

…nesis block Signed-off-by: Matilda Clerke <[email protected]>

Suggest garbage collection to try to avoid build up

9063878

Signed-off-by: Matilda Clerke <[email protected]>

Matilda-Clerke commented Apr 23, 2025

View reviewed changes

besu/src/main/java/org/hyperledger/besu/controller/BesuControllerBuilder.java Outdated Show resolved Hide resolved

garyschulte reviewed Apr 24, 2025

View reviewed changes

macfarla reviewed Apr 28, 2025

View reviewed changes

besu/src/main/java/org/hyperledger/besu/cli/options/ChainPruningOptions.java Outdated Show resolved Hide resolved

besu/src/main/java/org/hyperledger/besu/cli/options/ChainPruningOptions.java Outdated Show resolved Hide resolved

pinges reviewed Apr 28, 2025

View reviewed changes

Matilda-Clerke and others added 3 commits April 28, 2025 11:15

Fix missing space in option description in ChainPruningOptions.java

a0c3ce9

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]>

Fix missing space in option description in ChainPruningOptions.java

e9e5cb0

Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]>

Rework ChainDataPruner changes

823c930

Signed-off-by: Matilda Clerke <[email protected]>

jflo reviewed Apr 28, 2025

View reviewed changes

Gabriel-Trintinalia reviewed Apr 29, 2025

View reviewed changes

Remove System.gc call

d87b84a

Signed-off-by: Matilda Clerke <[email protected]>

siladu reviewed Apr 30, 2025

View reviewed changes

ahamlat previously requested changes Apr 30, 2025

View reviewed changes

Matilda-Clerke added 5 commits May 5, 2025 14:32

Move merge block number into NetworkName

24a954e

Signed-off-by: Matilda Clerke <[email protected]>

Throttle pre-merge pruning progress logs to one per 5 minutes

7ec3015

Signed-off-by: Matilda Clerke <[email protected]>

Allow different static data to have different garbage collection enab…

faa9a0f

…led status Signed-off-by: Matilda Clerke <[email protected]>

Update ChainDataPruner threadpool to match with metrics naming schemes

cb73c1a

Signed-off-by: Matilda Clerke <[email protected]>

Merge branch 'main' into 8337-modify-chain-data-pruner

ec9ba28

macfarla mentioned this pull request May 7, 2025

remove totalDifficulty from blockResult #8430

Draft

9 tasks

Add 1 second sleep at start of pre-merge pruning action

51173f6

Signed-off-by: Matilda Clerke <[email protected]>

siladu mentioned this pull request May 20, 2025

Add history-expiry-prune convenience flag to wrap prune GC settings #8654

Closed

macfarla added the history reduce disk reqs thru history mgmt label May 23, 2025

Update NetworkName.mergeBlockNumber to firstPosBlockNumber

7182cf8

Signed-off-by: Matilda Clerke <[email protected]>

macfarla reviewed May 23, 2025

View reviewed changes

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/ChainDataPruner.java Show resolved Hide resolved

siladu reviewed May 23, 2025

View reviewed changes

besu/src/main/java/org/hyperledger/besu/cli/options/ChainPruningOptions.java Outdated Show resolved Hide resolved

Merge branch 'main' into 8337-modify-chain-data-pruner

02390e5

siladu added this to History Expiry May 24, 2025

siladu moved this to In review in History Expiry May 24, 2025

Matilda-Clerke added 4 commits May 26, 2025 10:54

Change pre-merge block pruning enablement to use data flag

84eaf2c

Signed-off-by: Matilda Clerke <[email protected]>

Add stack trace to start of pruning debug log to debug source of mult…

c197b1e

…iple calls per expected call Signed-off-by: Matilda Clerke <[email protected]>

Move setIgnorableStorageSegments to after configure call

f5c3c65

Signed-off-by: Matilda Clerke <[email protected]>

Revert "Add stack trace to start of pruning debug log to debug source…

5769dea

… of multiple calls per expected call" This reverts commit c197b1e. Signed-off-by: Matilda Clerke <[email protected]>

Matilda-Clerke force-pushed the 8337-modify-chain-data-pruner branch from 4edd2f1 to 5769dea Compare May 26, 2025 23:49

Merge branch 'main' into 8337-modify-chain-data-pruner

d7f062f

Matilda-Clerke requested a review from siladu May 26, 2025 23:50

Matilda-Clerke added 5 commits May 27, 2025 10:05

Only execute preMergePruningAction for new canonical head

883ac25

Signed-off-by: Matilda Clerke <[email protected]>

spotless

a106767

Signed-off-by: Matilda Clerke <[email protected]>

Merge branch 'main' into 8337-modify-chain-data-pruner

be85913

Use checkpoint in genesis file and remove first PoS block from Networ…

c74540c

…kName Signed-off-by: Matilda Clerke <[email protected]>

Merge remote-tracking branch 'origin/8337-modify-chain-data-pruner' i…

229dfdb

…nto 8337-modify-chain-data-pruner

Matilda-Clerke added 4 commits May 29, 2025 15:21

Add unit test for new ChainDataPruner functionality

18479be

Signed-off-by: Matilda Clerke <[email protected]>

Merge branch 'main' into 8337-modify-chain-data-pruner

3dcfc69

Set default ChainDataPruner pre merge batch size to 100

67f7978

Signed-off-by: Matilda Clerke <[email protected]>

Merge remote-tracking branch 'origin/8337-modify-chain-data-pruner' i…

b03d76d

…nto 8337-modify-chain-data-pruner

siladu approved these changes May 29, 2025

View reviewed changes

Matilda-Clerke merged commit 1e084c7 into hyperledger:main May 29, 2025
48 checks passed

github-project-automation bot moved this from In review to Done in History Expiry May 29, 2025

8337 modify chain data pruner #8506

8337 modify chain data pruner #8506

Conversation

Matilda-Clerke commented Apr 2, 2025

PR description

Fixed Issue(s)

Uh oh!

Uh oh!

garyschulte Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Matilda-Clerke May 5, 2025

Choose a reason for hiding this comment

Uh oh!

garyschulte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pinges left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pinges Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Matilda-Clerke Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jflo Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

jflo Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

Gabriel-Trintinalia Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahamlat left a comment

Choose a reason for hiding this comment

Uh oh!

macfarla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Matilda-Clerke commented May 23, 2025

Uh oh!

Matilda-Clerke commented May 28, 2025

Uh oh!

siladu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

garyschulte Apr 24, 2025 •

edited

Loading