Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
If one looks at
Bytes
it is supposed to be an immutable structure so there wouldn't be any need for copying it inIDPrecompileContract
. However, looking closely at where this data comes from is required to know if the backingbyte[]
can also be mutated from other sources.Currently
inputData
that is passed to the ID precompile can only come from 3 sources:To me CALL seems to be the only place that is passing a
Bytes
instance that can be mutated later, so by making a copy of it before returning we ensure that modifying memory does not change the returnedBytes
instance.I'm also cutting off a bit of fat in
MessageFrame.readMemory
because we are actually copying the same data twice.This needs to go through performance benchmarks before gets pulled in and a full block import with mainnet to be safe.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests