-
-
Notifications
You must be signed in to change notification settings - Fork 73
Implement remote desktop portal #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey! I built this PR as well as the input-capture PR for Hyprland and tried them. Both RustDesk and KDEConnect can't do remote input, but input capture is working fine. RustDesk complains that I might need a newer version of libpipewire (surely not, I'm on Arch), while KDEConnect has a decent error message: Meanwhile, this is the Looking at dbus (using bustle), the portal responds properly to the requests but somehow the clients still crash. Do you have any remote control programs that work for you that I should try? Thanks for your effort, really hope this will be merged soon-ish :) |
|
Unfortunately I haven't implemented connecting to PipeWire yet, which is what KDEConnect and RustDesk rely on. KDEConnect also seems to use the Remote Desktop portal's methods instead of using a libei client, which I haven't tested yet, and my implementation of those methods may have caused that error From what I've used, InputLeap and lan-mouse (with libei backend) are functional, but there is no screen-sharing. Let me know if those don't work for you I'm quite busy atm but I'll try and look into it this week, thx for bringin it up |
|
Yeah, that makes sense. I tried lan-mouse from android, but that client had its own issues. Will try it with my desktop this evening. |
c298959 to
5d4660b
Compare
…apture protocol & cleanup
2cb4db6 to
bd845fc
Compare
This reverts commit d703e84.
bd845fc to
f74a227
Compare
|
this should be marked to fix #252 when landed. |
Describe your PR, what does it fix/add?
This PR implements the remote desktop portal with the wlr-virtual-pointer and virtual-keyboard protocol. This only works with 3l0w's hyprwm/Hyprland#7919 and hyprwm/hyprland-protocols#8
The RemoteDesktop portal makes client-side input-leap functional (as opposed to InputCapture, which is server-side).
also see 3l0w#1
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
There may be an issue with hyprwayland-scanner, which required me to patch virtual-keyboard-unstable-v1.cpp to create the virtual keyboard.
see hyprwm/hyprwayland-scanner#13 (comment)
Is it ready for merging, or does it need work?
it is a PR to a PR, it can only be merged once #268, hyprwm/Hyprland#7919 and hyprwm/hyprland-protocols#8, are merged.
also tell me if i did anything stupid