[browser/electron] drop core v3,v4 and electron < 35#305
Merged
Conversation
pankhur94
requested review from
MichaelSwigerAtBentley,
anmolshres98,
aruniverse and
ben-polinsky
as code owners
aruniverse
reviewed
May 30, 2025
Member
aruniverse
left a comment
aruniverse
left a comment
There was a problem hiding this comment.
lgtm;
lets make electron-auth bump a minor ver bump because its 0.x
i wonder if we should also update eslint in this pr
im guessing other auth client updates will be handled separately?
change/@itwin-electron-authorization-65bc18f2-c087-4733-a14c-d7724c8d29b8.json
Outdated
Show resolved
Hide resolved
MichaelSwigerAtBentley
approved these changes
May 30, 2025
…7724c8d29b8.json changing electron-auth changes from major to minor Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
Contributor
Author
yes I will be handling other auth-clients in a separate pr. Also, I’d recommend bumping ESLint in a separate PR, as it will likely involve additional changes. |
aruniverse
changed the title
aruniverse
reviewed
Jun 4, 2025
Collaborator
|
lets make electron-auth bump a minor ver bump because its 0.x Don't want to hit 1.0 :)? |
ben-polinsky
approved these changes
Jun 4, 2025
Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
pankhur94
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.