Skip to content

[ node-cli | oidc-signin-tool | service ] : Drop support for core v3 and v4#306

Merged
pankhur94 merged 13 commits intomainfrom
pankhur94/drop-support-for-pkgs
Jun 4, 2025
Merged

[ node-cli | oidc-signin-tool | service ] : Drop support for core v3 and v4#306
pankhur94 merged 13 commits intomainfrom
pankhur94/drop-support-for-pkgs

Conversation

@pankhur94
Copy link
Copy Markdown
Contributor

@pankhur94 pankhur94 commented Jun 2, 2025 •
edited
Loading

  • Drop support for core v3 & v4 from node-cli, oidc-signin-tool & service.
  • Bump oidc-client-ts and jwks-rsa to v3.
  • Use node v20.

@pankhur94 pankhur94 marked this pull request as ready for review June 2, 2025 19:02
ben-polinsky
ben-polinsky reviewed Jun 3, 2025
View reviewed changes
@pankhur94
Copy link
Copy Markdown
Contributor Author

pankhur94 commented Jun 3, 2025 •
edited
Loading

@aruniverse @ben-polinsky I notice that after updating oidc-client-ts to v4, our integ tests start failing in pipeline. I did check and that is because in v4, the package has dropped crypto-js which is leading to this error. I see that we use node v18, which doesn't have crypto in global. I tried updating node to v20 and it does work well and tests pass. I was just wondering if it is a good idea to update our node from v18 to v20 for our auth-client?

@aruniverse
Copy link
Copy Markdown
Member

aruniverse commented Jun 4, 2025

look at the version of nodejs that itwinjs supports as of 5.0

@pankhur94 pankhur94 mentioned this pull request Jun 4, 2025
Closed
MichaelSwigerAtBentley
MichaelSwigerAtBentley reviewed Jun 4, 2025
View reviewed changes
@pankhur94 @MichaelSwigerAtBentley
removing extra ";"
5f4f110 
Co-authored-by: Michael Swiger <108895074+MichaelSwigerAtBentley@users.noreply.github.com>
aruniverse
aruniverse reviewed Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we first get the browser-electron auth clients update pr through first?

pankhur94 and others added 2 commits June 4, 2025 12:44
@pankhur94 @aruniverse
Update change/@itwin-browser-authorization-463a9006-7adc-4ec0-b198-c8…
5e82fb7 
…91f747e7c5.json

Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
@pankhur94 @aruniverse
Update change/@itwin-browser-authorization-463a9006-7adc-4ec0-b198-c8…
a1749df 
…91f747e7c5.json

Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
@pankhur94
Copy link
Copy Markdown
Contributor Author

pankhur94 commented Jun 4, 2025 •
edited
Loading

can we first get the browser-electron auth clients update pr through first?

I was just waiting for you to approve it. Merged.

@pankhur94 pankhur94 merged commit ae310a6 into main Jun 4, 2025
13 checks passed
@pankhur94 pankhur94 deleted the pankhur94/drop-support-for-pkgs branch June 4, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-polinsky ben-polinsky ben-polinsky left review comments

@MichaelSwigerAtBentley MichaelSwigerAtBentley MichaelSwigerAtBentley left review comments

@aruniverse aruniverse aruniverse approved these changes

@anmolshres98 anmolshres98 Awaiting requested review from anmolshres98 anmolshres98 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pankhur94 @aruniverse @ben-polinsky @MichaelSwigerAtBentley