Skip to content

IBX-7880: Badge#8

Closed
albozek wants to merge 1 commit intomainfrom
IBX-7880-badge
Closed

IBX-7880: Badge#8
albozek wants to merge 1 commit intomainfrom
IBX-7880-badge

Conversation

@albozek
Copy link
Copy Markdown
Contributor

@albozek albozek commented Aug 25, 2025

🎫 Issue IBX-7880

Related PRs:

Description:

For QA:

Documentation:

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new badge component template for the Storybook documentation system. The change introduces a preview template that extends the base Storybook template and renders an Ibexa Badge component.

  • Adds a new Storybook preview template for the Badge component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

{% extends '@IbexaDesignSystemStorybook/themes/standard/storybook/base_preview.html.twig' %}

{% block component %}
<twig:ibexa:Badge {{ ...args }} />
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spread operator syntax {{ ...args }} is not valid Twig syntax. Use {% for key, value in args %}{{ key }}="{{ value }}"{% endfor %} or pass specific attributes explicitly.

Suggested change
<twig:ibexa:Badge {{ ...args }} />
<twig:ibexa:Badge {% for key, value in args %}{{ key }}="{{ value }}" {% endfor %}/>

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't listen to copilot, he doesn't know a thing! :P

{% extends '@IbexaDesignSystemStorybook/themes/standard/storybook/base_preview.html.twig' %}

{% block component %}
<twig:ibexa:Badge {{ ...args }} />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't listen to copilot, he doesn't know a thing! :P

@@ -0,0 +1,5 @@
{% extends '@IbexaDesignSystemStorybook/themes/standard/storybook/base_preview.html.twig' %}

{% block component %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't make any adjustments to properties, just passing all args to component, you can omit this file (and PR).

@albozek albozek closed this Sep 8, 2025
@albozek albozek deleted the IBX-7880-badge branch September 8, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants