Skip to content

IBX-7880: Badge #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albozek wants to merge 1 commit into from
Closed

IBX-7880: Badge #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/bundle/Resources/views/themes/standard/storybook/components/badge.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{% extends '@IbexaDesignSystemStorybook/themes/standard/storybook/base_preview.html.twig' %}

{% block component %}
Copy link
Copy Markdown
Contributor

@GrabowskiM GrabowskiM Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't make any adjustments to properties, just passing all args to component, you can omit this file (and PR).

<twig:ibexa:Badge {{ ...args }} />
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spread operator syntax {{ ...args }} is not valid Twig syntax. Use {% for key, value in args %}{{ key }}="{{ value }}"{% endfor %} or pass specific attributes explicitly.

Suggested change
<twig:ibexa:Badge {{ ...args }} />
<twig:ibexa:Badge {% for key, value in args %}{{ key }}="{{ value }}" {% endfor %}/>

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@GrabowskiM GrabowskiM Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't listen to copilot, he doesn't know a thing! :P

{% endblock component %}