You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I did not add any test since the issue occured in the already-implemented cases. Issue #1976 was caused by an error in the initialization of centroid positions.
@MassimoCimmino : Thanks for the changes. The verification fails due to a change in result of 0.4 K in one model, and in IBPSA.Utilities.Clustering.Validation.KMeans_1d, the returned clustering is different from the expected labelsExp. Can you please review and update as needed.
I updated labelsExp in IBPSA.Utilities.Clustering.Validation.KMeans_1d, IBPSA.Utilities.Clustering.Validation.KMeans_2d and IBPSA.Fluid.Geothermal.Borefields.BaseClasses.HeatTransfer.ThermalResponseFactors.Validation.ClusterBoreholes_100boreholes. The changes to IBPSA.Utilities.Clustering.KMeans enables the algorithm to find clusters with lower inertia. The difference in clusters in IBPSA.Fluid.Geothermal.Borefields.BaseClasses.HeatTransfer.ThermalResponseFactors.Validation.ClusterBoreholes_100boreholes would also explain the new results from the other models which use the same borefield geometry. I updated the results there also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #1985 and #1976.
I did not add any test since the issue occured in the already-implemented cases. Issue #1976 was caused by an error in the initialization of centroid positions.