Merge mesh generators#32847
Open
kyriv1980 wants to merge 6 commits intoidaholab:nextfrom
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
a81cd1d to
54e18e2
Compare
Contributor
|
Job Documentation, step Docs: sync website on c2bfa59 wanted to post the following: View the site here This comment will be updated on new commits. |
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
6154931 to
7ec291e
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
7ec291e to
54a9631
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
54a9631 to
194515e
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
194515e to
7340f6a
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
7340f6a to
21e0bb2
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
74bf3a9 to
cdb7692
Compare
Contributor
|
Job Precheck, step Clang format on cdb7692 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 28, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
cdb7692 to
651057a
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 29, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
651057a to
0bdb326
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 29, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
0bdb326 to
8c71acc
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 29, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
8c71acc to
0de0af5
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 29, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
0de0af5 to
fb51b06
Compare
Contributor
|
Job Precheck on fb51b06 : invalidated by @kyriv1980 |
1 similar comment
Contributor
|
Job Precheck on fb51b06 : invalidated by @kyriv1980 |
Contributor
|
Job Non unity build on fb51b06 : invalidated by @kyriv1980 |
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 29, 2026
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
fb51b06 to
f009851
Compare
Contributor
|
Job Precheck on f009851 : invalidated by @kyriv1980 |
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 30, 2026
Guard quad and tri assembly mesh generators against invalid axial grids, zero-length domains, and malformed spacer/blockage inputs before mesh construction. Keep quadrilateral assemblies consistent by rejecting only 1x1 layouts while allowing valid 1xN and Nx1 subchannel meshes. Fix triangular assembly block-id fallback handling so the deprecated block_id parameter is still honored when subchannel_block_id is not set. Also add a quad mesh-object guard so pin index lookup on no-pin 1xN/Nx1 meshes reports a clear error instead of evaluating unsigned underflow arithmetic. Add detailed quad coverage for the 1x1 rejection while preserving 1x2 and Nx1 generation behavior. Refs idaholab#32847
Contributor
|
Job Coverage, step Generate coverage on c2bfa59 wanted to post the following: Framework coverage
Modules coverageSubchannel
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 30, 2026
Remove unused detailed pin mesh generator code and an unused tri assembly helper. Make quad and tri power IC/Aux objects require a pin mesh and apply q_prime only on pin nodes. Update added-heat calculations to source heat from pin nodes only, returning zero for no-pin meshes. Refresh related power object documentation to match the pin-only behavior. Refs idaholab#32847
… tests and v&v cases, Refs idaholab#32796
Unify the triangular subchannel/pin mesh generators behind
SCMTriAssemblyMeshGenerator and SCMDetailedTriAssemblyMeshGenerator,
matching the earlier quad-generator merge and the new convention that
assembly generators build both subchannel and pin meshes when pins
exist.
This updates triangular inputs, tests, and registrations to use the new
assembly generator names directly and removes the old tri alias
registrations for consistency with the quad side.
While validating the merged detailed-tri path, fix several regressions:
- stop mutating TriSubChannelMesh from the detailed visualization generator
- avoid post-build renumbering in the detailed-tri assembly path
- copy _pin_nodes in TriSubChannelMesh copy construction
- assign unique element IDs to generated pin prisms by starting from
mesh_base->n_elem()
Also refresh the detailed triangular mesh test baseline to reflect the
new combined subchannel+pin mesh output and quiet its verbose debug
logging. Refs idaholab#32796
Guard quad and tri assembly mesh generators against invalid axial grids, zero-length domains, and malformed spacer/blockage inputs before mesh construction. Keep quadrilateral assemblies consistent by rejecting only 1x1 layouts while allowing valid 1xN and Nx1 subchannel meshes. Fix triangular assembly block-id fallback handling so the deprecated block_id parameter is still honored when subchannel_block_id is not set. Also add a quad mesh-object guard so pin index lookup on no-pin 1xN/Nx1 meshes reports a clear error instead of evaluating unsigned underflow arithmetic. Add detailed quad coverage for the 1x1 rejection while preserving 1x2 and Nx1 generation behavior. Refs idaholab#32847
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
dd50c20 to
5108bd0
Compare
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 30, 2026
Remove unused detailed pin mesh generator code and an unused tri assembly helper. Make quad and tri power IC/Aux objects require a pin mesh and apply q_prime only on pin nodes. Update added-heat calculations to source heat from pin nodes only, returning zero for no-pin meshes. Refresh related power object documentation to match the pin-only behavior. Refs idaholab#32847
kyriv1980
added a commit
to kyriv1980/moose
that referenced
this pull request
Apr 30, 2026
Remove unused detailed pin mesh generator code and an unused tri assembly helper. Make quad and tri power IC/Aux objects require a pin mesh and apply q_prime only on pin nodes. Update added-heat calculations to source heat from pin nodes only, returning zero for no-pin meshes. Refresh related power object documentation to match the pin-only behavior. Refs idaholab#32847
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
5108bd0 to
93f49ee
Compare
Remove unused detailed pin mesh generator code and an unused tri assembly helper. Make quad and tri power IC/Aux objects require a pin mesh and apply q_prime only on pin nodes. Update added-heat calculations to source heat from pin nodes only, returning zero for no-pin meshes. Refresh related power object documentation to match the pin-only behavior. Refs idaholab#32847
kyriv1980
force-pushed
the
mergeMeshGenerators
branch
from
93f49ee to
c2bfa59
Compare
Contributor
|
Job Test, step Results summary on c2bfa59 wanted to post the following: Framework test summaryCompared against 4e53b3b in job civet.inl.gov/job/3786076. No change Modules test summaryCompared against 4e53b3b in job civet.inl.gov/job/3786076. Removed tests
Added tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #32796