fix: upgrade qr code dep#240
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the react-qr-code dependency from version 2.0.3 to 2.0.18 and re-enables previously commented-out QR code functionality throughout the application. The changes also include a development configuration update to bind the server to all interfaces.
- Upgraded react-qr-code package to latest patch version (2.0.18)
- Re-enabled QR code components in topbar and sharing panels
- Updated development server host configuration
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates react-qr-code dependency from 2.0.3 to 2.0.18 |
| topbar.tsx | Uncomments QRCodeIcon import and component usage |
| panel_sharings.tsx | Uncomments QRCodeIcon import and component usage |
| dev.yml | Changes development server host from localhost to all interfaces |
| server: | ||
| debug: true | ||
| host: "127.0.0.1" | ||
| host: "0.0.0.0" |
There was a problem hiding this comment.
Changing the development server host from 127.0.0.1 to 0.0.0.0 exposes the server to all network interfaces, which could be a security risk in development environments. This change appears unrelated to the QR code dependency upgrade and should be justified or reverted.
Suggested change
| host: "0.0.0.0" | |
| host: "127.0.0.1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer following questions before creating the PR:
What is this PR about?
Is there any test which covers the change?