Skip to content

fix: upgrade qr code dep #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihexxa merged 1 commit into from
Jul 21, 2025
Merged

fix: upgrade qr code dep #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configs/dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ secrets:
tokenSecret: ""
server:
debug: true
host: "127.0.0.1"
host: "0.0.0.0"

Copilot AI Jul 21, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the development server host from 127.0.0.1 to 0.0.0.0 exposes the server to all network interfaces, which could be a security risk in development environments. This change appears unrelated to the QR code dependency upgrade and should be justified or reverted.

Suggested change
host: "0.0.0.0"
host: "127.0.0.1"

Copilot uses AI. Check for mistakes.
port: 8686
readTimeout: 2000
writeTimeout: 86400000 # 1 day
Expand Down
2 changes: 1 addition & 1 deletion src/client/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"react-copy-to-clipboard": "5.1.0",
"react-dom": "19.1.0",
"react-icons": "5.5.0",
"react-qr-code": "^2.0.3",
"react-qr-code": "^2.0.18",
"react-svg": "16.3.0",
"throttle-debounce": "^4.0.1",
"webpack-bundle-analyzer": "^4.4.2",
Expand Down
4 changes: 2 additions & 2 deletions src/client/web/src/components/panel_sharings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from "react";
import { List, Map } from "immutable";

import { BtnList } from "./control/btn_list";
// import { QRCodeIcon } from "./visual/qrcode";
import { QRCodeIcon } from "./visual/qrcode";
import { getErrMsg } from "../common/utils";
import { Env } from "../common/env";
import { updater } from "./state_updater";
Expand Down Expand Up @@ -107,7 +107,7 @@ export class SharingsPanel extends React.Component<Props, State, {}> {
<Flexbox
children={List([
<span className="margin-r-m">
{/* <QRCodeIcon value={sharingURL} size={128} pos={false} /> */}
<QRCodeIcon value={sharingURL} size={128} pos={false} />
</span>,

<button
Expand Down
14 changes: 7 additions & 7 deletions src/client/web/src/components/topbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { updater } from "./state_updater";
import { Flexbox } from "./layout/flexbox";
import { ctrlOn, ctrlHidden, settingsDialogCtrl } from "../common/controls";
import { Container } from "./layout/container";
// import { QRCodeIcon } from "./visual/qrcode";
import { QRCodeIcon } from "./visual/qrcode";

export interface State {}
export interface Props {
Expand Down Expand Up @@ -71,12 +71,12 @@ export class TopBar extends React.Component<Props, State, {}> {
<span className="text-[1rem] leading-default minor-font">
{this.props.ui.clientCfg.siteDesc}
</span>,
// <QRCodeIcon
// value={document.URL}
// size={128}
// pos={true}
// className="margin-l-m"
// />,
<QRCodeIcon
value={document.URL}
size={128}
pos={true}
className="margin-l-m"
/>,

<Flexbox
children={List([
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4332,12 +4332,12 @@ react-is@^17.0.1:
resolved "https://registry.npmjs.org/react-is/-/react-is-17.0.2.tgz"
integrity sha512-w2GsyukL62IJnlaff/nRegPQR94C/XXamvMWmSHRJ4y7Ts/4ocGRmTHvOs8PSE6pB3dWOrD/nueuU5sduBsQ4w==

react-qr-code@^2.0.3:
version "2.0.3"
resolved "https://registry.npmjs.org/react-qr-code/-/react-qr-code-2.0.3.tgz"
integrity sha512-6GDH0l53lksf2JgZwwcoS0D60a1OAal/GQRyNFkMBW19HjSqvtD5S20scmSQsKl+BgWM85Wd5DCcUYoHd+PZnQ==
react-qr-code@^2.0.18:
version "2.0.18"
resolved "https://registry.yarnpkg.com/react-qr-code/-/react-qr-code-2.0.18.tgz#237de8fbab537885d6b2b10f4fd5318b371e3b17"
integrity sha512-v1Jqz7urLMhkO6jkgJuBYhnqvXagzceg3qJUWayuCK/c6LTIonpWbwxR1f1APGd4xrW/QcQEovNrAojbUz65Tg==
dependencies:
prop-types "^15.7.2"
prop-types "^15.8.1"
qr.js "0.0.0"

react-svg@*:
Expand Down
Loading