Change when damage info dialog popup, when targeting enemy unit with damage spells #10211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now ALL damage spells will show a DamageInfo dialog when tageting a _defender
1 task
zenseii
added
improvement
Owner
|
Hi @Stisen1 , please do the following:
|
Stisen1
changed the title
Stisen1
changed the title
Changed a bit of the todo text, because one solution creates a new problem to be solved further down the road. A new issue should be made: "When targeting multiple enemy units with damage spells: highlight nearest single target and show damage-info dialog"
Contributor
Author
|
Done, right? |
Owner
|
Hi @Stisen1 , I think to be fair to spells with multiple targets it's important to indicate that the total damage is going to be higher than the one only for the first target. One way is to add "+" symbol at the end of the value to highlight that an additional damage. What do you think? |
Contributor
Author
|
Yeah. Or: Damage: 40-?? or Damage: 40-20-10-5 |
ihhub
approved these changes
Dec 1, 2025
ihhub
changed the title
Districh-ru
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10035
ALL damage spells should show a DamageInfo-dialog, when targeting a _defender (single target unit)