Skip to content

Change when damage info dialog popup, when targeting enemy unit with damage spells #10211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stisen1 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change when damage info dialog popup, when targeting enemy unit with damage spells #10211

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
865c77f
Update battle_interface.cpp
Stisen1 Sep 27, 2025
6054661
Update TODO comment
Stisen1 Sep 29, 2025
e3834fe
Reword the comment
ihhub Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/fheroes2/battle/battle_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7032,9 +7032,8 @@ void Battle::PopupDamageInfo::setSpellAttackInfo( const HeroBase * hero, const U
{
assert( hero != nullptr );

// TODO: Currently, this functionality only supports a simple single-target spell case
// We should refactor this to apply to all cases
if ( !spell.isSingleTarget() || !spell.isDamage() ) {
// TODO: any multi-unit damage spells show only damage of the first unit or one of the units on whom the spell is being applied (ex. Cold Ring)
if ( !spell.isDamage() ) {
return;
}

Expand Down
Loading