Skip to content

Model 29.1 Anemia YLDs #275

Open
tylerdy wants to merge 4 commits intoepic/anemia_yldsfrom
tylerdy/model-29.1
Open

Model 29.1 Anemia YLDs #275
tylerdy wants to merge 4 commits intoepic/anemia_yldsfrom
tylerdy/model-29.1

Conversation

@tylerdy
Copy link
Collaborator

@tylerdy tylerdy commented Feb 18, 2026

Model 29.1 Anemia YLDs

Description

Changes and notes

  • Removes oral iron effect on hemoglobin
  • Adds pregnancy outcome stratification to anemia YLDs observer

Results in

/mnt/team/simulation_science/pub/models/vivarium_gates_mncnh/results/model29.1/ethiopia/2026_02_17_13_50_47/results
/mnt/team/simulation_science/pub/models/vivarium_gates_mncnh/results/model29.1/pakistan/2026_02_17_13_51_55/results
/mnt/team/simulation_science/pub/models/vivarium_gates_mncnh/results/model29.1/nigeria/2026_02_17_13_52_38/results

Verification and Testing

Anemia YLDs results contain pregnancy outcomes stratification.

*** REMINDER ***
CI WILL NOT RUN ANY TESTS.
MANUALLY RUN TESTS WITH EACH PR.
MAKE SURE CONSTANTS/PATHS.PY IS USING THE CORRECT MODEL RESULTS DIRECTORY.
-->

  • model results directory is up to date
  • all tests pass (pytest --runslow with both vivarium_gates_mncnh_artifact and vivarium_gates_mncnh_simulation)
simulation:
================================ 7 passed, 8 skipped, 84 warnings in 92.70s (0:01:32) =================================

@zmbc
Copy link
Contributor

zmbc commented Feb 18, 2026

Should this have a base branch of epic/anemia_ylds? Looks like there are some commits from Hussain in the diff

@tylerdy tylerdy changed the base branch from main to epic/anemia_ylds February 18, 2026 18:47
@zmbc
Copy link
Contributor

zmbc commented Feb 18, 2026

@tylerdy two more things:

  • I don't see the outputs of running the tests in this PR.
  • The model_dir constant was not updated.

@zmbc
Copy link
Contributor

zmbc commented Feb 18, 2026

Looked into the model_dir issue, and it appears that additionally:

  • This model was only run for one location (Pakistan)
  • The model results directory was not named consistently with other model runs

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, you don't need to do the Path(result_dir / observation_dir).glob('*') part -- you can simply use pd.read_parquet with the directory name. But this notebook will be deleted soon anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments