Complete tutorial implementation and results processing#1606
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
zmbc
added
the
meta modeling strategy
SylLutze
left a comment
SylLutze
left a comment
There was a problem hiding this comment.
I think this looks awesome!! Excited to turn Tyler and the JKUAT team loose on this.
| @@ -2,7 +2,17 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
Line #76. "Wasting Between -3 SD and -2 SD (post-ensemble)",
Is this slow? Have string comparisons in a call like this makes me nervous.
Reply via ReviewNB
There was a problem hiding this comment.
Hm, fair question. I could map the strings to integers on the comparator rather than the column side, which would be more performant.
But I know from this profile of the simulation overall that this is not a hotspot. So probably not worth going back and changing now.
|
Note: @tylerdy made comments on the notebook rather than the PR, they can be seen here: https://app.reviewnb.com/ihmeuw/vivarium_research/blob/tutorial_implementation/docs/source/onboarding_resources/tutorial/index.ipynb/#comment-a34e06df |
|
@tylerdy Here are the changes I made in response to your comments: https://app.reviewnb.com/ihmeuw/vivarium_research/commit/9416c817c1aed42e695469b13de45d114da10104/ |
tylerdy
left a comment
tylerdy
left a comment
There was a problem hiding this comment.
These changes look great, super helpful!
alibow
left a comment
alibow
left a comment
There was a problem hiding this comment.
This is awesome! Thanks for putting this all together Zeb. I left some comments in the notebook :)
|
@alibow I've addressed your comments here: https://app.reviewnb.com/ihmeuw/vivarium_research/commit/3dd465b99878c58923d2e54ce5a7822847976bad/ |
@zmbc all these changes look great to me! Thanks :) |
5 participants
No description provided.