Skip to content

Conversation

@khaeru
Copy link
Member

@khaeru khaeru commented Apr 1, 2021

This PR uses the new iiasa/actions repo and setup-gams action to install GAMS on GitHub Actions runners.

This approach is more modular and simple than the prior approach of checking out the ixmp repo and calling a script contained there.

Other changes:

  • Also use the ts-graphviz/setup-graphviz action, which does essentially the same thing as the Bash script used from ixmp
  • Remove code in message_ix.testing.nightly that handles the GAMS license upload and download. The new action uses license file contents stored as a repository secret.

How to review

No review; CI changes only.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A; CI changes only
  • Update release notes.

@khaeru khaeru added the ci Continuous integration label Apr 1, 2021
@khaeru khaeru self-assigned this Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #452 (0e1c9ea) into master (9efac12) will increase coverage by 0.0%.
The diff coverage is 90.0%.

❗ Current head 0e1c9ea differs from pull request most recent head a568e5e. Consider uploading reports for the commit a568e5e to get more accurate results

@@          Coverage Diff           @@
##           master    #452   +/-   ##
======================================
  Coverage    93.3%   93.3%           
======================================
  Files          37      37           
  Lines        2798    2800    +2     
======================================
+ Hits         2611    2613    +2     
  Misses        187     187           
Impacted Files Coverage Δ
message_ix/tools/add_year/__init__.py 66.2% <66.6%> (+0.1%) ⬆️
message_ix/tests/reporting/test_computations.py 100.0% <100.0%> (ø)
message_ix/tests/test_core.py 100.0% <100.0%> (ø)
message_ix/tests/test_feature_addon.py 100.0% <100.0%> (ø)
...age_ix/tests/test_feature_bound_activity_shares.py 100.0% <100.0%> (ø)
message_ix/tests/test_feature_bound_emission.py 100.0% <100.0%> (ø)
message_ix/tests/test_feature_price_commodity.py 100.0% <100.0%> (ø)
message_ix/tests/test_feature_price_emission.py 100.0% <100.0%> (ø)
message_ix/tests/test_feature_storage.py 92.4% <100.0%> (ø)
message_ix/tests/test_macro.py 100.0% <100.0%> (ø)
... and 2 more

@khaeru
Copy link
Member Author

khaeru commented Apr 1, 2021

The Windows tests appear to all pass, but the step is failing:

XFAIL message_ix/tests/test_core.py::test_add_horizon[args7-kwargs7-None]
XFAIL message_ix/tests/test_core.py::test_add_horizon[args8-kwargs8-None]
==== 113 passed, 2 deselected, 5 xfailed, 4 warnings in 444.20s (0:07:24) =====
Error: Process completed with exit code 1.

Needs further investigation.

@khaeru khaeru force-pushed the gams-action branch 3 times, most recently from 4309b3e to 9e23d49 Compare April 1, 2021 18:42
@khaeru khaeru force-pushed the gams-action branch 2 times, most recently from 67d84d2 to 78b9c16 Compare April 2, 2021 10:04
@khaeru
Copy link
Member Author

khaeru commented Apr 2, 2021

Needs further investigation.

I'll temporarily exclude this in order to unblock other PRs, e.g. #451, and then open a new PR to re-enable and debug it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant