This repository was archived by the owner on Nov 16, 2024. It is now read-only.
Open
Conversation
Owner
|
Wow @cherbst, your pull request looks pretty nice! Thanks a lot, will look at it more carfully really soon. |
before, if the taxonomy slug also occured in the term slug, then the term slug was also prefixed with the bp group slug
Owner
|
I'm sorry i forgot to commit a fix for BuddyPress 2.7. I'm going to commit it. So this will probably have an impact on this pull request. |
imath
suggested changes
Dec 23, 2016
Owner
imath
left a comment
imath
left a comment
There was a problem hiding this comment.
After a quick look, i think it's important to make sure your changes are also working on network installs. And according to this line https://github.com/imath/bp-groups-taxo/pull/15/files?diff=unified#diff-8d79d3ae70c6906dd6d01c479fccbe91R112 it doesn't seem to be the case. Could you give another look?
|
I'd love the see this PR merged. Can it be fixed? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows multiple taxonomies for groups. Adds a filter for themes/plugins to override taxonomies.