Refactor: update Turnstile field to extend the new security challenge field #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
glaubersilva
suggested changes
Apr 8, 2025
There was a problem hiding this comment.
@jonwaldstein Great work! The submission is working as expected. I just left a comment related to a minor thing. Also, I noticed the unit tests are broken. The Copilot is showing some steps to fix it here: https://github.com/copilot/c/0835a420-db3f-4a09-8edb-011e3421209e
|
@glaubersilva suggestion resolved. Also the tests will probably fail until the dependent Give branch is merged so i'll keep an eye on that. |
glaubersilva
approved these changes
Apr 9, 2025
jonwaldstein
deleted the
refactor/implement-security-challenge-field-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2349
Depends on: impress-org/givewp#7865
Description
This updates the CloudFlare Turnstile field to implement the SecurityChallenge field added in GiveWP Core.
This will ensure Turnstile will not attempt to be validated on the server before the final form submission endpoint.
Affects
Visuals
Screen.Recording.2025-04-07.at.2.31.47.PM.mov
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks