Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add SecurityChallenge Field to Fields API #7865

Merged
merged 4 commits into from
Apr 10, 2025

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Apr 7, 2025

Partially Resolves GIVE-2349

Related: impress-org/give-cloudflare-turnstile#1

Description

Security challenge fields are a special snowflake. They can typically only be validated once on the server. Extending this new abstract field will ensure that the field is not validated on the server before the form is fully submitted, avoiding our current pre-validation endpoint.

Affects

  • Will currently only affect CloudFlare Turnstile

Visuals

N/A

Testing Instructions

See related PR for testing instructions: impress-org/give-cloudflare-turnstile#1

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review April 7, 2025 18:05
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwaldstein Nice work! Ready to go! 🚀

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein merged commit d3dffd8 into develop Apr 10, 2025
24 checks passed
@jonwaldstein jonwaldstein deleted the feature/security-challenge-field-api branch April 10, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants