-
Notifications
You must be signed in to change notification settings - Fork 75
added babel for messages extraction #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
babel.cfg
Outdated
|
|
||
| [jinja2: **/templates/**.html] | ||
| encoding = utf-8 | ||
| trimmed = true No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please configure your editor to end files with a linebreka
newdle/templates/base_email.html
Outdated
| <td style="text-align: center; color: #aaa; font-size: 11px; padding-bottom: 10px;"> | ||
| <p style="padding: 0 50px; margin-top: 10px;"> | ||
| This email was sent by <a href="{{ url_for('index', _external=true) }}">newdle</a>. | ||
| {% trans %}This email was sent by{% endtrans %} <a href="{{ url_for('index', _external=true) }}">newdle</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have partial sentences in translatable strings. The link must be part of it. You can do something like this:
{% set newdle_link -%}
<a href="{{ url_for('index', _external=true) }}">newdle</a>
{%- endset %}
{% trans %}This email was sent by {{ newdle_link }}.{% endtrans %}| {% block content %} | ||
| <p> | ||
| Hi {{ participant }}, you have a fresh newdle! | ||
| {% trans %}"Hi {{ participant }}, you have a fresh newdle!"{% endtrans %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {% trans %}"Hi {{ participant }}, you have a fresh newdle!"{% endtrans %} | |
| {% trans %}Hi {{ participant }}, you have a fresh newdle!{% endtrans %} |
|
Hi, i've fixed the extension error and now i have this error on the git ci and cannot commit
this has always been there and i don't know why it's bothering him now but it might need to be changed https://docs.astral.sh/ruff/rules/log-exception-outside-except-handler/ |
|
Maybe just add a |
#503