Fix #417 Add serviceMonitor template for the telegraf chart#510
Fix #417 Add serviceMonitor template for the telegraf chart#510Efrat19 wants to merge 13 commits intoinfluxdata:masterfrom
Conversation
Signed-off-by: Efrat19 <efrat890089@gmail.com>
Signed-off-by: Efrat19 <efrat890089@gmail.com>
alespour
left a comment
alespour
left a comment
There was a problem hiding this comment.
Could you please bump chart version.
…af_servicemonitor
Signed-off-by: Efrat19 <efrat890089@gmail.com>
|
Hey is there anything else still needed to be done here? @tomklapka @alespour |
…af_servicemonitor
Signed-off-by: Efrat Levitan <efrat890089@gmail.com>
|
Checks failed with Error: ServiceMonitor.monitoring.coreos.com "telegraf-1xv72y61rr" is invalid: spec.endpoints.port: Invalid value: "integer": spec.endpoints.port in body must be of type string: "integer". Please fix it. |
fixed |
|
@Efrat19 please rebase your branch to master and bump up the telegraf chart version (1.8.23 -> 1.8.24) Thank you. |
|
@Efrat19 Can you please finish this PR,as it is useful for integrating with prometheus usages. |
| {{- range $key, $value := . -}} | ||
| {{- $tp := typeOf $value -}} | ||
| {{- if eq $key "prometheus_client" }} | ||
| - port: {{ trimPrefix ":" $value.listen }} |
There was a problem hiding this comment.
{{ (trimPrefix ":" $value.listen) | quote }} can correct the type issues.it is string instead of number
4 participants
Signed-off-by: Efrat19 efrat890089@gmail.com
addressing #417