-
Notifications
You must be signed in to change notification settings - Fork 346
Fix #417 Add serviceMonitor template for the telegraf chart #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Efrat19
wants to merge
13
commits into
influxdata:master
Choose a base branch
from
Efrat19:feat/417_add_telegraf_servicemonitor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fa10243
add template and vals for a service monitor
Efrat19 18b3afa
revert value test
Efrat19 e77ffae
Merge remote-tracking branch 'origin/master' into feat/417_add_telegr…
Efrat19 fb34acd
add labels and bump the chart version
Efrat19 208c7ff
test: add Prometheus monitor test values
alespour 2fcdd44
chore: extend CI tests error checking
alespour c09cd65
chore: import custom resources
alespour d246437
chore: make install check fail asap on error
alespour 940c83e
Merge remote-tracking branch 'origin/master' into feat/417_add_telegr…
Efrat19 a28618f
add values
Efrat19 1ed3854
fix type error
Efrat19 1e3ef13
Merge branch 'master' into feat/417_add_telegraf_servicemonitor
tomklapka 0361991
Update Chart.yaml
Efrat19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| Error loading config file | ||
| Release not loaded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| config: | ||
| outputs: | ||
| - prometheus_client: | ||
| listen: ":9273" | ||
| serviceMonitor: | ||
| create: true | ||
| labels: | ||
| team: losers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| {{- if .Values.serviceMonitor.create }} | ||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: ServiceMonitor | ||
| metadata: | ||
| name: {{ template "telegraf.serviceMonitorName" . }} | ||
| namespace: {{ .Values.serviceMonitor.namespaceOverride | default .Release.Namespace }} | ||
| labels: | ||
| {{- include "telegraf.labels" . | nindent 4 }} | ||
|
alespour marked this conversation as resolved.
|
||
| {{- if .Values.serviceMonitor.labels }} | ||
| {{- toYaml .Values.serviceMonitor.labels | nindent 4 }} | ||
| {{- end }} | ||
| {{- if .Values.serviceMonitor.annotations }} | ||
| annotations: | ||
| {{- toYaml .Values.serviceMonitor.annotations | nindent 4 }} | ||
| {{- end }} | ||
| spec: | ||
| selector: | ||
| matchLabels: | ||
| {{- include "telegraf.labels" . | nindent 6 }} | ||
| namespaceSelector: | ||
| matchNames: | ||
| - {{ .Release.Namespace }} | ||
| endpoints: | ||
| {{- range $objectKey, $objectValue := .Values.config.outputs }} | ||
| {{- range $key, $value := . -}} | ||
| {{- $tp := typeOf $value -}} | ||
| {{- if eq $key "prometheus_client" }} | ||
| - port: {{ trimPrefix ":" $value.listen }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. {{ (trimPrefix ":" $value.listen) | quote }} can correct the type issues.it is string instead of number |
||
| path: {{ $value.path | default "/metrics" }} | ||
| {{- end }} | ||
| {{- end -}} | ||
| {{- end }} | ||
| {{- end }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.