chore(code): Move mode check for effect handling in engine #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
ancazamfir
changed the title
3 tasks
romac
reviewed
Mar 26, 2025
romac
reviewed
Mar 26, 2025
code/crates/engine/src/consensus.rs
Outdated
Comment on lines
957
to
960
| let should_broadcast = match &msg { | ||
| SignedConsensusMsg::Vote(_) => true, | ||
| _ => value_payload.include_proposal(), | ||
| }; |
There was a problem hiding this comment.
Let's refactor this into a function that we can use here and for the WAL below
There was a problem hiding this comment.
I think for the WAL we will have to remove the check when we fix #897. So we have three options
- refactor now and undo when we fix code: WAL scenarios for Proposal #897
- leave things as they are
- fix code: WAL scenarios for Proposal #897 in this PR
This was referenced Apr 7, 2025
* Move proposal and vote signature verification in the engine * Cleanup Resume variants and updates to adr-004 * Move certificate verification in the engine
5 tasks
✅ Semver Check PassedGreat job! All semver violations have been resolved. This PR now complies with semantic versioning rules. If you made version updates, please ensure that:
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
PR author checklist
For all contributors
For external contributors