Skip to content

chore(code): Move mode check for effect handling in engine #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

chore(code): Move mode check for effect handling in engine #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2ab53cb
Move mode check on effect handling in enging
ancazamfir Mar 25, 2025
ed73f5d
Generate proposal for PartsOnly in the engine
ancazamfir Mar 26, 2025
32357a7
Revert "Generate proposal for PartsOnly in the engine"
ancazamfir Mar 26, 2025
a991cb4
Merge branch 'main' into anca/engine_effect_handling
ancazamfir Apr 8, 2025
813b60d
Fix bad paranthesis
ancazamfir Apr 8, 2025
e8a9777
chore(code): Move the signature verification in the engine (#973)
ancazamfir Apr 9, 2025
0662a6a
Generate proposal for PartsOnly in the engine
ancazamfir Apr 9, 2025
1fd4e2d
Move proposal-only check in the engine
ancazamfir Apr 9, 2025
518514a
Extension verification in its own method
ancazamfir Apr 10, 2025
db6e898
Move value_payload mode from consensus params to the engine actor
ancazamfir Apr 10, 2025
d4df1c8
Merge branch 'main' into anca/engine_effect_handling
ancazamfir Apr 10, 2025
206818f
Merge branch 'main' into anca/engine_effect_handling
ancazamfir Apr 28, 2025
23c5a2b
Update minor version number and document breaking changes
ancazamfir May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions BREAKING_CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@

### `malachitebft-engine`
- Changed the reply channel of `GetValidatorSet` message to take an `Option<Ctx::ValidatorSet>` instead of `Ctx::ValidatorSet`.
- All signature verification logic has been moved from the consensus core to the engine, including:
- Proposal signatures
- Vote signatures
- Certificate signatures
- Extension signatures
- Removed `Effect::Verify*` and `Resume::*Validity` variants as verification is now handled by the engine
- Removed `Effect::GetValidatorSet` as it's no longer needed for pre-buffer verification
- Moved consensus mode (`value_payload`) handling from consensus core to engine

### `malachitebft-core-consensus`
- Removed `value_payload` from `ConsensusParams`

## 0.2.0

Expand Down
64 changes: 32 additions & 32 deletions code/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

60 changes: 30 additions & 30 deletions code/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ members = [
]

[workspace.package]
version = "0.2.1-pre"
version = "0.3.0-pre"
edition = "2021"
readme = "README.md"
repository = "https://github.com/informalsystems/malachite"
Expand All @@ -67,39 +67,39 @@ disallowed_types = "deny"
doc_overindented_list_items = "allow"

[workspace.dependencies]
malachitebft-engine = { version = "0.2.1-pre", package = "informalsystems-malachitebft-engine", path = "crates/engine" }
malachitebft-app = { version = "0.2.1-pre", package = "informalsystems-malachitebft-app", path = "crates/app" }
malachitebft-app-channel = { version = "0.2.1-pre", package = "informalsystems-malachitebft-app-channel", path = "crates/app-channel" }
malachitebft-codec = { version = "0.2.1-pre", package = "informalsystems-malachitebft-codec", path = "crates/codec" }
malachitebft-config = { version = "0.2.1-pre", package = "informalsystems-malachitebft-config", path = "crates/config" }
malachitebft-core-consensus = { version = "0.2.1-pre", package = "informalsystems-malachitebft-core-consensus", path = "crates/core-consensus" }
malachitebft-core-driver = { version = "0.2.1-pre", package = "informalsystems-malachitebft-core-driver", path = "crates/core-driver" }
malachitebft-core-state-machine = { version = "0.2.1-pre", package = "informalsystems-malachitebft-core-state-machine", path = "crates/core-state-machine" }
malachitebft-core-types = { version = "0.2.1-pre", package = "informalsystems-malachitebft-core-types", path = "crates/core-types" }
malachitebft-core-votekeeper = { version = "0.2.1-pre", package = "informalsystems-malachitebft-core-votekeeper", path = "crates/core-votekeeper" }
malachitebft-discovery = { version = "0.2.1-pre", package = "informalsystems-malachitebft-discovery", path = "crates/discovery" }
malachitebft-network = { version = "0.2.1-pre", package = "informalsystems-malachitebft-network", path = "crates/network" }
malachitebft-metrics = { version = "0.2.1-pre", package = "informalsystems-malachitebft-metrics", path = "crates/metrics" }
malachitebft-peer = { version = "0.2.1-pre", package = "informalsystems-malachitebft-peer", path = "crates/peer" }
malachitebft-proto = { version = "0.2.1-pre", package = "informalsystems-malachitebft-proto", path = "crates/proto" }
malachitebft-signing-ed25519 = { version = "0.2.1-pre", package = "informalsystems-malachitebft-signing-ed25519", path = "crates/signing-ed25519" }
malachitebft-sync = { version = "0.2.1-pre", package = "informalsystems-malachitebft-sync", path = "crates/sync" }
malachitebft-wal = { version = "0.2.1-pre", package = "informalsystems-malachitebft-wal", path = "crates/wal" }
malachitebft-engine = { version = "0.3.0-pre", package = "informalsystems-malachitebft-engine", path = "crates/engine" }
malachitebft-app = { version = "0.3.0-pre", package = "informalsystems-malachitebft-app", path = "crates/app" }
malachitebft-app-channel = { version = "0.3.0-pre", package = "informalsystems-malachitebft-app-channel", path = "crates/app-channel" }
malachitebft-codec = { version = "0.3.0-pre", package = "informalsystems-malachitebft-codec", path = "crates/codec" }
malachitebft-config = { version = "0.3.0-pre", package = "informalsystems-malachitebft-config", path = "crates/config" }
malachitebft-core-consensus = { version = "0.3.0-pre", package = "informalsystems-malachitebft-core-consensus", path = "crates/core-consensus" }
malachitebft-core-driver = { version = "0.3.0-pre", package = "informalsystems-malachitebft-core-driver", path = "crates/core-driver" }
malachitebft-core-state-machine = { version = "0.3.0-pre", package = "informalsystems-malachitebft-core-state-machine", path = "crates/core-state-machine" }
malachitebft-core-types = { version = "0.3.0-pre", package = "informalsystems-malachitebft-core-types", path = "crates/core-types" }
malachitebft-core-votekeeper = { version = "0.3.0-pre", package = "informalsystems-malachitebft-core-votekeeper", path = "crates/core-votekeeper" }
malachitebft-discovery = { version = "0.3.0-pre", package = "informalsystems-malachitebft-discovery", path = "crates/discovery" }
malachitebft-network = { version = "0.3.0-pre", package = "informalsystems-malachitebft-network", path = "crates/network" }
malachitebft-metrics = { version = "0.3.0-pre", package = "informalsystems-malachitebft-metrics", path = "crates/metrics" }
malachitebft-peer = { version = "0.3.0-pre", package = "informalsystems-malachitebft-peer", path = "crates/peer" }
malachitebft-proto = { version = "0.3.0-pre", package = "informalsystems-malachitebft-proto", path = "crates/proto" }
malachitebft-signing-ed25519 = { version = "0.3.0-pre", package = "informalsystems-malachitebft-signing-ed25519", path = "crates/signing-ed25519" }
malachitebft-sync = { version = "0.3.0-pre", package = "informalsystems-malachitebft-sync", path = "crates/sync" }
malachitebft-wal = { version = "0.3.0-pre", package = "informalsystems-malachitebft-wal", path = "crates/wal" }

# Test
malachitebft-test = { version = "0.2.1-pre", package = "informalsystems-malachitebft-test", path = "crates/test" }
malachitebft-test-app = { version = "0.2.1-pre", package = "informalsystems-malachitebft-test-app", path = "crates/test/app" }
malachitebft-test-cli = { version = "0.2.1-pre", package = "informalsystems-malachitebft-test-cli", path = "crates/test/cli" }
malachitebft-test-mbt = { version = "0.2.1-pre", package = "informalsystems-malachitebft-test-mbt", path = "crates/test/mbt" }
malachitebft-test-mempool = { version = "0.2.1-pre", package = "informalsystems-malachitebft-test-mempool", path = "crates/test/mempool" }
malachitebft-test-framework = { version = "0.2.1-pre", package = "informalsystems-malachitebft-test-framework", path = "crates/test/framework" }
malachitebft-discovery-test = { version = "0.2.1-pre", package = "informalsystems-malachitebft-discovery-test", path = "crates/network/test" }
malachitebft-test = { version = "0.3.0-pre", package = "informalsystems-malachitebft-test", path = "crates/test" }
malachitebft-test-app = { version = "0.3.0-pre", package = "informalsystems-malachitebft-test-app", path = "crates/test/app" }
malachitebft-test-cli = { version = "0.3.0-pre", package = "informalsystems-malachitebft-test-cli", path = "crates/test/cli" }
malachitebft-test-mbt = { version = "0.3.0-pre", package = "informalsystems-malachitebft-test-mbt", path = "crates/test/mbt" }
malachitebft-test-mempool = { version = "0.3.0-pre", package = "informalsystems-malachitebft-test-mempool", path = "crates/test/mempool" }
malachitebft-test-framework = { version = "0.3.0-pre", package = "informalsystems-malachitebft-test-framework", path = "crates/test/framework" }
malachitebft-discovery-test = { version = "0.3.0-pre", package = "informalsystems-malachitebft-discovery-test", path = "crates/network/test" }

# Starknet
malachitebft-starknet-host = { version = "0.2.1-pre", package = "informalsystems-malachitebft-starknet-host", path = "crates/starknet/host" }
malachitebft-starknet-app = { version = "0.2.1-pre", package = "informalsystems-malachitebft-starknet-app", path = "crates/starknet/app" }
malachitebft-starknet-p2p-proto = { version = "0.2.1-pre", package = "informalsystems-malachitebft-starknet-p2p-proto", path = "crates/starknet/p2p-proto" }
malachitebft-starknet-p2p-types = { version = "0.2.1-pre", package = "informalsystems-malachitebft-starknet-p2p-types", path = "crates/starknet/p2p-types" }
malachitebft-starknet-host = { version = "0.3.0-pre", package = "informalsystems-malachitebft-starknet-host", path = "crates/starknet/host" }
malachitebft-starknet-app = { version = "0.3.0-pre", package = "informalsystems-malachitebft-starknet-app", path = "crates/starknet/app" }
malachitebft-starknet-p2p-proto = { version = "0.3.0-pre", package = "informalsystems-malachitebft-starknet-p2p-proto", path = "crates/starknet/p2p-proto" }
malachitebft-starknet-p2p-types = { version = "0.3.0-pre", package = "informalsystems-malachitebft-starknet-p2p-types", path = "crates/starknet/p2p-types" }

# Starknet
starknet-core = "0.11.1"
Expand Down
2 changes: 1 addition & 1 deletion code/crates/app/src/spawn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ where
initial_validator_set,
address,
threshold_params: Default::default(),
value_payload,
vote_sync_mode,
};

Consensus::spawn(
ctx,
value_payload,
consensus_params,
cfg.timeouts,
signing_provider,
Expand Down
Loading