Skip to content

visual confirmation of room reset is missing - #257

Open
maxones25 wants to merge 8 commits into
devfrom
fix/Visual_confirmation_of_room_reset_is_missing
Open

visual confirmation of room reset is missing#257
maxones25 wants to merge 8 commits into
devfrom
fix/Visual_confirmation_of_room_reset_is_missing

Conversation

@maxones25

@maxones25 maxones25 commented Sep 27, 2021

Copy link
Copy Markdown
Collaborator

Related Issue

Proposed Changes

  • if the room reset fails, an alert message will be displayed.

Additional Info

Checklist

  • Is the code formatted correctly?
  • Unnecessary comments removed?
  • Printout statements removed?
  • If you made backend changes: Did all tests pass? Do you need to adjust some tests or write new ones?
  • If you made frontend changes: Did you test the UI on different devices/ browsers (Firefox, Chrome, Safari, different smartphone sizes)
  • Is your code easy to understand or do you need to insert some comments?
  • Explain the issue for the reviewer and your steps to solve the issue => makes it a lot more easy for the reviewer
  • Label your pull request (frontend/ backend/ testing/ styling/ sql/...)
  • Is the open source message included at the very beginning of every source code file?
  • Are all imports organized, i.e. are the imports up to date and have all package imports been removed?

@maxones25 maxones25 linked an issue Sep 27, 2021 that may be closed by this pull request
@oliverhummel

Copy link
Copy Markdown
Contributor

There still seems to be no message or whatsoever when the reset was successful?

@maxones25

Copy link
Copy Markdown
Collaborator Author

There still seems to be no message or whatsoever when the reset was successful?

Currently, there is no dialog or alert. Only the current room visits number goes down to 0 (i am working on the issue, that the privileged visitor stays in the room). Is that sufficient?

@oliverhummel

Copy link
Copy Markdown
Contributor

My suggestions ist that there does not need to be a dialog, just a message on the similar to our "cookie banner" saying that the room has been emptied.

Regarding the person that does the reset, I am not sure. I currently use this function mostly to check-out everybody (including myself) from a room after a lecture. Hence, I want to be checked out as well.

Maybe a checkbox would be helpful to stay checked in? However, if this is significant in terms of effort, I think we have more important issues to deal with..?

@oliverhummel
oliverhummel force-pushed the fix/Visual_confirmation_of_room_reset_is_missing branch from dfd5ed1 to 1249fce Compare September 30, 2021 16:51
@oliverhummel

Copy link
Copy Markdown
Contributor

This still needs a message, dialog or toast saying that the room was reset. Ideally something the user can, but does not have to click away.

@Gabril-E
Gabril-E self-requested a review November 18, 2021 16:36
@Gabril-E
Gabril-E requested review from Androx765 and removed request for Gabril-E December 2, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual confirmation of room reset is missing

3 participants