ci(sim): keep the asset bakes cached across branches - #771
Open
DavidDobas wants to merge 2 commits into
Open
Conversation
Split the CoACD bake out of build_environment_pack.py into decompose_pack.py, the only script copied into the bake layer, so an edit to the finish step no longer re-bakes every pack. Branch publishes read main's buildcache and write only their own cache-<branch> ref; main alone writes buildcache, so a branch can no longer evict main's 17-minute apartment bake.
Contributor
Greptile SummaryThis PR separates expensive environment-pack decomposition from the finishing stage and isolates registry build caches by branch.
Confidence Score: 5/5The PR appears safe to merge with no outstanding actionable findings. The latest changes use Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Publish workflow] --> B{PUSH_MAIN_TAGS?}
B -->|true| C[Read buildcache]
C --> D[Write buildcache]
B -->|false| E[Read buildcache]
E --> F[Read cache-ref-slug-hash]
F --> G[Write cache-ref-slug-hash]
H[Raw environment GLB] --> I[decompose_pack.py]
I --> J[Cached CoACD hull layer]
J --> K[build_environment_pack.py]
K --> L[Visual meshes, nav map, viewer assets]
Reviews (2): Last reviewed commit: "ci(sim): key the shared asset cache off ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #767. #753's asset publish still re-baked the apartment (8 min) and the backrooms (12 min); two reasons, two fixes.
build_environment_pack.pytosim/tools/decompose_pack.py, which is the only script the bake layer copies. Editing the finish step (visuals, nav map, viewer glb) no longer re-bakes a pack.build_environment_pack.pynow runs the finish step alone.buildcacheand evicted main's bakes. Branches now read main'sbuildcacheplus their owncache-<branch>and write only their own. Main alone writesbuildcache.sha-tag and are not in the keep-forever list, socleanup-sim-images.ymlages them out after 14 days without a push.This branch's own publish bakes the backrooms once (new bake-layer key); the apartment stays cached.
Verified:
ruff,tests/(76 passed),docker build --check -f sim/Dockerfile.assets, both tools load the backrooms scene to the same 29 parts and floor as before.