-
Notifications
You must be signed in to change notification settings - Fork 114
fix(YouTube/Music): prevent GC pressure concurrence #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@inotia00 take this change with a grain of salt. The only test I did was on my main device, and it worked. Let others who have problems with battery consumption also try it out. |
It would be great if someone implement Aho Corasick as a replacement of the Litho Component's Trie Search |
Almost useless, considering the general app performance without any bottleneck, such as 1.000.000 threads (and LinkedHashMap elements) spawned in matter of seconds to fetch the video stream. Anyway...this is the second day in a row that I can reproduce the same battery behaviour with uTube, without any sign of overheating and "concurrence GC freed..." logs printed every second. But I need other tests from other users, to have a confirmations about this fix. |
I don't think so. From my side, RVX seems laggy when scrolling in feed. After that I untick all component-hiding patches and problem is no longer occur. Therefore, I sure that the cause is from the large amount of litho filter in RVX, which let the app itself do several search in litho and cause delay in layout update. |
I had the same problem, but become noticeable only when video stream threads start to spamming in memory, otherwise the app was smooth enough. In any case I converted every List and Stream of strings, in a Set of strings. This gave me a further smoothness. Try to use this object type. |
@YT-Advanced (for curiosity) I implemented the Aho-Corsack algorithm on my uTube client. I just need to fix one thing and I'll push the new code. If you're interested, use the uDrop patcher and try it on your device. 👍 |
Cool. I will check it soon |
@YT-Advanced Done. Try it! 👍 P.S: Seems really fast at a first look. |
Nice work. U can use this ones as a dependency instead |
@YT-Advanced Pushed! 👍 |
a3a4aa0
to
fb5d5bb
Compare
@YT-Advanced Try it! 👍 |
This issue can lead to a battery consuption increase of 5/10% per hour.