Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Jan 20, 2026

Description

Modify Validator::validate return type.
Do not return boolean flag which is a duplication of the filling doc.report().

Related Issue(s)

Part of #634

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

  • Validator::validate return type. Instead of relying on the returned boolean flag, use doc.report().is_problematic()

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Jan 20, 2026
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Jan 20, 2026
@github-actions
Copy link
Contributor

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/chore/validate-interface

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 715/715}$ | ${\color{red}Fail: 0/715}$ |

@Mr-Leshiy Mr-Leshiy merged commit 61ea052 into main Jan 20, 2026
42 of 45 checks passed
@Mr-Leshiy Mr-Leshiy deleted the chore/validate-interface branch January 20, 2026 20:05
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants