Skip to content

fix(/prob-revshare): make table accessible#212

Merged
DarianM merged 8 commits intomainfrom
193-bug-revenue-share-generator-accesability-part-2
Aug 11, 2025
Merged

fix(/prob-revshare): make table accessible#212
DarianM merged 8 commits intomainfrom
193-bug-revenue-share-generator-accesability-part-2

Conversation

@kjmitchelljr
Copy link
Copy Markdown
Collaborator

@kjmitchelljr kjmitchelljr commented Jul 31, 2025

Resolves #193 by adding suggested accessibility features for the Revenue Share Generator Table having tested the following items

  • Screen readers can navigate and understand the data structure
  • All input fields have proper accessible names
  • Column headers are associated with their data
  • Validation errors are announced to screen readers
  • Keyboard navigation works smoothly
  • Component maintains responsive design

@kjmitchelljr kjmitchelljr self-assigned this Jul 31, 2025
@kjmitchelljr kjmitchelljr linked an issue Jul 31, 2025 that may be closed by this pull request
6 tasks
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Jul 31, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
publisher-tools 403b3a9 Commit Preview URL Aug 11 2025, 05:40 PM

@kjmitchelljr kjmitchelljr force-pushed the 193-bug-revenue-share-generator-accesability-part-2 branch from 1c875c4 to b8c317f Compare July 31, 2025 02:22
@DarianM DarianM moved this from Backlog to In Progress in Publisher Tools Jul 31, 2025
@DarianM DarianM moved this from In Progress to In Review in Publisher Tools Jul 31, 2025
@adrianboros
Copy link
Copy Markdown
Contributor

@kjmitchelljr besides VoiceOver use this accessibility tool to find and fix other accessibility related issues for all pages:
see this PR report:
https://wave.webaim.org/report#/https://7f76198d-publisher-tools.webmonetization.workers.dev/tools/

@DarianM
Copy link
Copy Markdown
Member

DarianM commented Aug 6, 2025

@kjmitchelljr besides VoiceOver use this accessibility tool to find and fix other accessibility related issues for all pages: see this PR report: https://wave.webaim.org/report#/https://7f76198d-publisher-tools.webmonetization.workers.dev/tools/

@adrianboros @kjmitchelljr @sidvishnoi We can take one route at a time, most accessibility issues are due to low contrast, which should be resolved at the global level. The /rev-share route looks good in my book and in Lighthouse accessibility.

Comment thread frontend/app/components/redesign/components/revshare/ShareInput.tsx Outdated
Comment thread frontend/app/components/redesign/components/revshare/ShareInput.tsx Outdated
@sidvishnoi sidvishnoi changed the title fix(accessibility): added accessibility features for rev share generator fix(/prob-revshare): make table accessible Aug 6, 2025
@kjmitchelljr
Copy link
Copy Markdown
Collaborator Author

Thanks for the input guys, will look into making some of these changes/updates!

@kjmitchelljr kjmitchelljr force-pushed the 193-bug-revenue-share-generator-accesability-part-2 branch from 60514dd to 804ee14 Compare August 7, 2025 18:44
@kjmitchelljr
Copy link
Copy Markdown
Collaborator Author

@sidvishnoi @DarianM is this good to be merged?

@DarianM DarianM merged commit 403f671 into main Aug 11, 2025
5 checks passed
@DarianM DarianM deleted the 193-bug-revenue-share-generator-accesability-part-2 branch August 11, 2025 17:41
@github-project-automation github-project-automation bot moved this from In Review to Done in Publisher Tools Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Revenue share generator accesability, part 2

4 participants