Skip to content

user list settings: disable save button on modal on click, re-enable if error happens#875

Merged
iisa merged 1 commit intomasterfrom
disable-list-settings-on-submit
Oct 17, 2023
Merged

user list settings: disable save button on modal on click, re-enable if error happens#875
iisa merged 1 commit intomasterfrom
disable-list-settings-on-submit

Conversation

@iisa
Copy link
Copy Markdown
Contributor

@iisa iisa commented Oct 11, 2023

No description provided.

@iisa iisa enabled auto-merge (squash) October 11, 2023 01:12
Comment thread packages/ia-userlist-settings/src/ia-user-list-settings.ts
Copy link
Copy Markdown
Contributor

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question; otherwise, LGTM.

@iisa
Copy link
Copy Markdown
Contributor Author

iisa commented Oct 13, 2023

closing to use #877

@iisa iisa closed this Oct 13, 2023
auto-merge was automatically disabled October 13, 2023 16:25

Pull request was closed

@iisa iisa reopened this Oct 13, 2023
Comment thread packages/ia-userlist-settings/src/ia-user-list-settings.ts
@iisa iisa merged commit 339e2a8 into master Oct 17, 2023
@iisa iisa deleted the disable-list-settings-on-submit branch October 17, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants