Skip to content

user list settings: disable save button on modal on click, re-enable if error happens #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iisa merged 1 commit into from
Oct 17, 2023
Merged

user list settings: disable save button on modal on click, re-enable if error happens #875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/ia-userlist-settings/src/ia-user-list-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ export class IAUserListSettings extends LitElement {

private async saveListDetails(event: Event) {
event.preventDefault();
const submitButton = (event.target as HTMLElement)?.querySelector('button#save-list-settings');
Comment thread
iisa marked this conversation as resolved.
submitButton?.setAttribute('disabled', 'true');
Comment thread
iisa marked this conversation as resolved.

try {
const userListData: UserListOptions = {
Expand Down Expand Up @@ -71,11 +73,13 @@ export class IAUserListSettings extends LitElement {
})
);
console.log('error', error);
submitButton?.removeAttribute('disabled');
}
}

private emitCloseModalEvent() {
this.dispatchEvent(new CustomEvent('listModalClosed'));
private emitCloseModalEvent(e: Event) {
e.preventDefault();
this.dispatchEvent(new Event('listModalClosed'));
}

render() {
Expand Down Expand Up @@ -116,7 +120,7 @@ export class IAUserListSettings extends LitElement {
>
Cancel
</button>
<button type="submit" class="ia-button primary">Save</button>
<button type="submit" id="save-list-settings" class="ia-button primary">Save</button>
</div>
</form>
</section>
Expand Down