Fix: Hide loading indicator if carousel loading fails.

[SAYAN02-DEV]

Closes #11380

fix: This feature hides the carousel loading indicator if carousel loading fails.

Technical

In openlibrary/openlibrary/plugins/openlibrary/js/lazy-carousel.js in catch block I added a condition to check if loadingIndicator is visible a then loadingIndicator.classList.add('hidden');
hides the loadingIndicator.

.catch(() => {
            if(loadingIndicator){
                loadingIndicator.classList.add('hidden');
            }
            const retryElem = target.querySelector('.lazy-carousel-retry')
            retryElem.classList.remove('hidden')
        })

Screenshot

before:

after:

[Copilot]

Pull Request Overview

This PR adds defensive null-checking before hiding the loading indicator in the error handler of the lazy carousel functionality. This prevents potential runtime errors when the loading indicator element doesn't exist.

• Added null check for loadingIndicator in the catch block before attempting to hide it

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jimchamp]

Suggested change

	if (loadingIndicator){
	loadingIndicator.classList.add('hidden');
	}
	loadingIndicator.classList.add('hidden');

loadingIndicator will exist, and is accessed in the previous then call. No need for the if statement here.

[jimchamp]

That is to say: This will always be true regardless of the element being hidden.

[jimchamp]

Thanks @SAYAN02-DEV.

As things are today, your if condition will always be true. Please remove it.

[jimchamp]

That is to say: This will always be true regardless of the element being hidden.

[SAYAN02-DEV]

@jimchamp I got it and removed the if condition.