fix: migrate registration newsletter to native HTML checkbox

[akramcodez]

Closes #10731

Changes

• Replaced custom Checkbox logic with standard HTML checkbox
• Updated registration form and template to use default behavior
• Verified checked boxes now correctly post values, unchecked omitted

Screenshot

Stakeholders

@jimchamp

[akramcodez]

PTAL @jimchamp, thanks.

[Copilot]

Pull Request Overview

This PR refactors the Internet Archive newsletter checkbox from being a form-rendered input to a hardcoded HTML input in the signup template.

• Removes the ia_newsletter Checkbox field from the RegisterForm class
• Adds direct HTML checkbox markup for ia_newsletter in the template
• Updates the i18n message location from Python forms file to the HTML template

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
openlibrary/plugins/upstream/forms.py	Removes the ia_newsletter Checkbox field definition from RegisterForm
openlibrary/templates/account/create.html	Adds hardcoded HTML checkbox input for ia_newsletter with inline label
openlibrary/i18n/messages.pot	Moves the newsletter checkbox text translation entry from forms.py to account/create.html

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[akramcodez]

could anyone please suggest if I can make both checkboxes the same?

[jimchamp]

Thanks @akramcodez! This is nearly ready to be merged, you'll just need to do the following:

• Replace the other Checkbox that is used on the registration page with HTML
• Remove the Checkbox definition.

Please ensure that you are assigned to issues before working on them in the future.

[akramcodez]

@jimchamp done :)

[jimchamp]

Almost there -- you forgot to remove the Checkbox definition

[akramcodez]

@jimchamp Sorry for my previous mistake. I’ve deleted the unwanted things now. If there’s any problem let me know.

[jimchamp]

Thanks @akramcodez!