Skip to content

fix: migrate registration newsletter to native HTML checkbox #11400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimchamp merged 10 commits into from
Dec 4, 2025
+18 −49
Merged

fix: migrate registration newsletter to native HTML checkbox #11400

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1d35703
fix: migrate registration newsletter to native HTML checkbox
akramcodez Oct 31, 2025
a7a2c70
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2025
d8877a1
refactor: use translation function for newsletter label in account cr…
akramcodez Oct 31, 2025
b7af701
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2025
f4f0ef3
Merge branch 'internetarchive:master' into fix/native-newsletter-chec…
akramcodez Nov 4, 2025
a5b094a
Merge branch 'internetarchive:master' into fix/native-newsletter-chec…
akramcodez Dec 3, 2025
6b36c27
refactor: replace pd_request checkbox with raw input in RegisterForm …
akramcodez Dec 3, 2025
e164cba
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 3, 2025
0925edc
refactor: remove unused Checkbox class definition
akramcodez Dec 4, 2025
42eee21
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions openlibrary/i18n/messages.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1453,13 +1453,6 @@ msgstr ""
msgid "Public and cannot be changed later."
msgstr ""

#: openlibrary/plugins/upstream/forms.py
msgid ""
"I want to receive news, announcements, and resources from the <a "
"href=\"https://archive.org/\">Internet Archive</a>, the non-profit that "
"runs Open Library."
msgstr ""

#: openlibrary/plugins/upstream/forms.py
msgid ""
"I want to apply* for <a href=\"https://help.archive.org/help/program-"
Expand Down Expand Up @@ -2485,6 +2478,13 @@ msgstr ""
msgid "screenname"
msgstr ""

#: account/create.html
msgid ""
"I want to receive news, announcements, and resources from the <a "
"href=\"https://archive.org/\">Internet Archive</a>, the non-profit that "
"runs Open Library."
msgstr ""

#: account/create.html
msgid "Select qualifying program"
msgstr ""
Expand Down
8 changes: 0 additions & 8 deletions openlibrary/plugins/upstream/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,6 @@ class RegisterForm(Form):
maxlength="20",
required="true",
),
Checkbox(
'ia_newsletter',
description=_(
'I want to receive news, announcements, and resources from the '
'<a href="https://archive.org/">Internet Archive</a>, the non-profit '
'that runs Open Library.'
),
),
Checkbox(
"pd_request",
description=_(
Expand Down
3 changes: 2 additions & 1 deletion openlibrary/templates/account/create.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ <h1 class="ol-signup-hero__title">$_("Sign Up")</h1>
$:field(form.password)

<div class="ol-signup-form__checkbox">
$:form.ia_newsletter.render() <label for="ia_newsletter">$:form.ia_newsletter.description</label>
<input type="checkbox" id="ia_newsletter" name="ia_newsletter"/>
<label for="ia_newsletter">$:_('I want to receive news, announcements, and resources from the <a href="https://archive.org/">Internet Archive</a>, the non-profit that runs Open Library.')</label>
</div>
<div id="rpd-checkbox" class="ol-signup-form__checkbox">
$:form.pd_request.render() <label for="pd_request">$:form.pd_request.description</label>
Expand Down
Loading