Better connection strings

[egabancho]

No description provided.

[plesoun-stein]

we have cloudnative postgres operator and all params are in secret.
It should be nice to specify password from secret

helper should look like

{{- define "invenio.postgresql.password" -}}
  {{- if .Values.postgresql.enabled -}}
    {{- required "Missing .Values.postgresql.auth.password" .Values.postgresql.auth.password -}}
  {{- else if and ( not .Values.postgresql.enabled ) ( not ( empty .Values.postgresqlExternal.password )) -}}
    {{- .Values.postgresqlExternal.password -}}
  {{- else if and ( not .Values.postgresql.enabled ) ( empty .Values.postgresqlExternal.password ) ( not ( empty  .Values.postgresqlExternal.existingSecret )) }}
    {{- $obj := (lookup "v1" "Secret" $root.Release.Namespace .Values.postgresqlExternal.existingSecret ).data }}
    {{- if or ( empty $obj ) ( empty ( get $obj .Values.postgresqlExternal.existingSecretPasswordKey )) -}}
      {{- fail ( printf "\n\n\tthere is missing secret \`%s\` or password key \`%s\`" .Values.postgresqlExternal.existingSecret .Values.postgresqlExternal.existingSecretPasswordKey ) }}
    {{- end -}}
    {{- printf "%s" ( get $obj ( tpl .Values.postgresqlExternal.existingSecretPasswordKey . ) | b64dec )  }}
  {{- else -}}
    {{- fail ( printf "\n\n\tInternal postgresql chart is disabled and there is missing .Values.postgresqlExternal.existingSecret declaration or another mistake or typo\n\n%s" ( toYaml .Values.postgresqlExternal | indent 6 )) }}
  {{- end -}}
{{- end -}}

(it's not tested, only example as POC)
simmilar work may be done for other params. hostname, username etc.
and I cat write it reusable for rabbit and redis

I have a time and I can do it.

[egabancho]

@lindhe, Take another look 😉

[lindhe]

I think maybe my merge via GitHub went wrong, because something is badly broken right now. I've reset to your last commit. Checking things again now…

[lindhe]

There's a bunch of relatively minor comments here. But in my last test, I think the values looked pretty broken when I ran env in the container. I'll see if I can narrow down that issue while we're addressing my other comments here.

[lindhe]

It seems to work well, but I'm a bit confused with these variables:

$ kubectl exec deploy/invenio-web -c web -- env |  grep RABBITMQ_PORT
INVENIO_RABBITMQ_PORT_25672_TCP=tcp://10.43.72.254:25672
INVENIO_RABBITMQ_PORT_4369_TCP_ADDR=10.43.72.254
INVENIO_RABBITMQ_PORT_25672_TCP_ADDR=10.43.72.254
INVENIO_RABBITMQ_PORT_15672_TCP_ADDR=10.43.72.254
INVENIO_RABBITMQ_PORT_15672_TCP_PROTO=tcp
INVENIO_RABBITMQ_PORT=tcp://10.43.72.254:5672
INVENIO_RABBITMQ_PORT_25672_TCP_PORT=25672
INVENIO_RABBITMQ_PORT_5672_TCP_ADDR=10.43.72.254
INVENIO_RABBITMQ_PORT_25672_TCP_PROTO=tcp
INVENIO_RABBITMQ_PORT_5672_TCP_PROTO=tcp
INVENIO_RABBITMQ_PORT_4369_TCP_PORT=4369
INVENIO_RABBITMQ_PORT_5672_TCP_PORT=5672
INVENIO_RABBITMQ_PORT_4369_TCP_PROTO=tcp
INVENIO_RABBITMQ_PORT_4369_TCP=tcp://10.43.72.254:4369
INVENIO_RABBITMQ_PORT_15672_TCP=tcp://10.43.72.254:15672
INVENIO_RABBITMQ_PORT_15672_TCP_PORT=15672
INVENIO_RABBITMQ_PORT_5672_TCP=tcp://10.43.72.254:5672

I guess they are just strangely named variables in the container, not something we've set here that gets messed up, right?

Misclick

[egabancho]

I don't see any of these variables in any of the containers I have (using my old branch with these changes). But, judging from the name, they might be some k8s thingy?

[lindhe]

If you are happy with the changes now, I think this is ready to merge. 🙂

[max-moser]

i'm not familiar enough to make a call with helm charts, but it looks like there was a discussion and it got accepted – so i moved it to "to release"

[lindhe]

@max-moser I still have some unresolved comments. No release yet.

[egabancho]

I can't approve the PR because I made it 😛
@lindhe, if you're happy with it, I am happy with it.

[lindhe]

I can't approve the PR because I made it 😛 @lindhe, if you're happy with it, I am happy with it.

Thanks. I'll add the last change with comments that I mentioned, then I'll approve. Then you merge if you are happy with my changes. 😛

[lindhe]

Turns out I already made that change, totally forgot about that! 😄 I think this looks good now. I'll just one quick test to see that I didn't miss something obvious, then I'll approve.