fix: file not possible to delete if it fails between operations#2319
Open
Ducica wants to merge 1 commit intoinveniosoftware:masterfrom
Open
fix: file not possible to delete if it fails between operations#2319Ducica wants to merge 1 commit intoinveniosoftware:masterfrom
Ducica wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
* if file upload fails for example on commit, it is not possible to * remove it from the UI by clicking on trash can
Ducica
force-pushed
the
oarepo-contribution-file-upload-bug
branch
from
4b1333c to
7619a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Screen.Recording.2026-04-15.at.9.23.07.mov
When file upload fails at another step, like for example commit, it is no longer possible to remove it from the UI. It is because, files links are not actually saved in redux in any of the steps, and so delet operation does not actually have self linke available. This happens both with old uploader and with Uppy uploader. Now unfortunately, the flow that two uploaders use is different, so it is not possible to have a fully unified solution for both, so I tried to make the solution touch as little as possible.
Please let us know if this makes sense for you.