feat+refactor: log call site of deprecated Link rather than definition [+] #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenekku
changed the title
fenekku
commented
Nov 5, 2025
| return { | ||
| # to be verified if needed, since the models are dynamically created | ||
| "invenio_db.model": [ | ||
| "mock_module_factory = tests.mock_module_factory.grant", |
Contributor
Author
There was a problem hiding this comment.
didn't exist and not needed.
fenekku
commented
Nov 5, 2025
| assert rec_type.resource_config_cls.url_prefix == "/resourcetests" | ||
| assert rec_type.resource_config_cls.blueprint_name == "resourcetest" | ||
|
|
||
| # links_schema_class = rec_type.resource_config_cls.links_config["record"] |
Contributor
Author
There was a problem hiding this comment.
below tests that links_item and links_search setup. Then, all tests that use the service validate that the defined links work (they fail in response serialization like .data otherwise).
fenekku
commented
Nov 5, 2025
| "Link is deprecated and will be removed in v14.0. Use `ExternalLink` for " | ||
| "third-party links and `EndpointLink` for InvenioRDM links.", | ||
| DeprecationWarning, | ||
| stacklevel=2, |
Contributor
Author
There was a problem hiding this comment.
This is the important bit.
fenekku
force-pushed
the
link_usage_warning_2
branch
from
ae09429 to
dfe0840
Compare
- This keeps same interface, simply moves away from deprecated approach - Makes DeprecationWarning log where deprecated Link is *used* (useful) rather than where the warning call is defined (not so useful)
fenekku
force-pushed
the
link_usage_warning_2
branch
from
dfe0840 to
2dba88a
Compare
fenekku
commented
Nov 24, 2025
| "links_search": pagination_links("{+api}" + route + "{?args*}"), | ||
| "links_search": pagination_endpoint_links( | ||
| f"{self.record_name_lower}.search" | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
This actually alters URL encoding which could cause tests in other repos to fail e.g., https://github.com/inveniosoftware/invenio-vocabularies/pull/517/files#r2556476359 . I am submitting PRs that fix those, so it will just be a matter of merging them when this one is merged and released.
fenekku
force-pushed
the
link_usage_warning_2
branch
from
2232aee to
07a4484
Compare
Contributor
Author
|
Ok this is ready for review with passing tests now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than where the warning call is defined (not so useful). This will highlight where Link is still used in other module tests, so that move to EndpointLink/ExternalLink can be done. For example, tests of invenio-drafts-resources using this updated module will log:
telling us that invenio-users-resources uses deprecated Link in
users/config.py:214.