feat: support float32 datatype
#31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmmx
changed the title
float32 datatype
…ut type inference
…sting behaviour fail the test
|
Build success! 🎉 The Bray Curtis test is passing uint64, I only put in support for float32, it seems like this was silently being cast to float64 too. It makes sense to keep the behaviour, but that makes this no longer just a float32 PR (so perfect time to squash and re-submit it!) |
|
I'm going to squash this one into a new branch ready to review/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting a PR in to iterate on #17 (lots of warnings I will address and only covered euclidean distance so far, but tests are passing 👍 )