-
Couldn't load subscription status.
- Fork 11
feat(array): f32 and uint64 support
#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
OK wonderful, that should do it :-) I added a little more detail to the opening PR comment This PR now looks sound to me, but it'd be good to have test coverage that can confirm that the behaviour is indeed preserved from the original implementation, for all the array functions edit - test coverage supplied in 8128ba9 |
| compute_array_distance( | ||
| x, | ||
| y, | ||
| "bray_curtis", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could maybe use an enum for this in the future
|
@lmmx great work! |
This one is ready for review @ion-elgreco ! 🎉
Overview
Background - Squashed branch carried over from #31 renamed to reflect that it provides initial float32 and uint64 support for the array distance methods, build and tests are passing
Status I'd be happy to merge this and submit the further method coverage in a fresh PR. I think what's left is:
list.rsstring.rsI expect the rest will be less work now, but I also note that there are no tests for those parts so perhaps it might turn out to be more due to having to introduce testing before making the changes.
More details
distance_calc_uint_inpanddistance_calc_numeric_inpfunctions out of the expressions module and into the array module as it is only used for array dtype inputsvector_distance_calcwhich gets reused for everything (I'd like to do some further testing to ensure this does indeed retain the same behaviour)