-
Notifications
You must be signed in to change notification settings - Fork 35
chore: add multiple PR templates for github #6982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lzpap
wants to merge
3
commits into
develop
Choose a base branch
from
multiple-pr-templates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
.github/PULL_REQUEST_TEMPLATE/default_external_contributors.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# Description of change | ||
|
||
Please write a summary of your changes and why you made them. | ||
|
||
## Links to any relevant issues | ||
|
||
Be sure to reference any related issues by adding `fixes #(issue)`. | ||
|
||
## How the change has been tested | ||
|
||
Describe the tests that you ran to verify your changes. | ||
|
||
Make sure to provide instructions for the maintainer as well as any relevant configurations. | ||
|
||
- [ ] Basic tests (linting, compilation, formatting, unit/integration tests) | ||
- [ ] Patch-specific tests (correctness, functionality coverage) | ||
- [ ] I have added tests that prove my fix is effective or that my feature works | ||
- [ ] I have checked that new and existing unit tests pass locally with my changes | ||
|
||
## Change checklist | ||
|
||
Tick the boxes that are relevant to your changes, and delete any items that are not. | ||
|
||
- [ ] I have followed the [contribution guidelines](../../CONTRIBUTING.md) for this project | ||
- [ ] I have performed a self-review of my own code | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have made corresponding changes to the documentation | ||
|
||
### Release Notes | ||
|
||
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. | ||
|
||
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. | ||
|
||
- [ ] Protocol: | ||
- [ ] Nodes (Validators and Full nodes): | ||
- [ ] Indexer: | ||
- [ ] JSON-RPC: | ||
- [ ] GraphQL: | ||
- [ ] CLI: | ||
- [ ] Rust SDK: | ||
- [ ] REST API: |
25 changes: 25 additions & 0 deletions
25
.github/PULL_REQUEST_TEMPLATE/default_internal_contributors.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Description of change | ||
|
||
Please write a summary of your changes and why you made them. | ||
|
||
## Links to any relevant issues | ||
|
||
Be sure to reference any related issues by adding `fixes #(issue)`. | ||
|
||
## How the change has been tested | ||
|
||
- [ ] Basic tests (linting, compilation, formatting, unit/integration tests) | ||
- [ ] Patch-specific tests (correctness, functionality coverage) | ||
- [ ] I have added tests that prove my fix is effective or that my feature works | ||
- [ ] I have checked that new and existing unit tests pass locally with my changes | ||
|
||
### Release Notes | ||
|
||
- [ ] Protocol: | ||
- [ ] Nodes (Validators and Full nodes): | ||
- [ ] Indexer: | ||
- [ ] JSON-RPC: | ||
- [ ] GraphQL: | ||
- [ ] CLI: | ||
- [ ] Rust SDK: | ||
- [ ] REST API: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Description of change | ||
|
||
Please write a summary of your changes and why you made them. | ||
|
||
## Links to any relevant issues | ||
|
||
Be sure to reference any related issues by adding `fixes #(issue)`. | ||
|
||
## How the change has been tested | ||
|
||
Describe the tests that you ran to verify your changes. | ||
|
||
Make sure to provide instructions for the maintainer as well as any relevant configurations. | ||
|
||
- [ ] Basic tests (linting, compilation, formatting, unit/integration tests) | ||
- [ ] Patch-specific tests (correctness, functionality coverage) | ||
|
||
### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) | ||
|
||
- [ ] Synchronization of the indexer from genesis for a network including migration objects. | ||
- [ ] Restart of indexer synchronization locally without resetting the database. | ||
- [ ] Restart of indexer synchronization on a production-like database. | ||
- [ ] Deployment of services using Docker. | ||
- [ ] Verification of API backward compatibility. | ||
|
||
### Release Notes | ||
|
||
- [ ] Protocol: | ||
- [ ] Nodes (Validators and Full nodes): | ||
- [ ] Indexer: | ||
- [ ] JSON-RPC: | ||
- [ ] GraphQL: | ||
- [ ] CLI: | ||
- [ ] Rust SDK: | ||
- [ ] REST API: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,61 +1,5 @@ | ||
# Description of change | ||
Please go to the `Preview` tab and select the appropriate sub-template: | ||
|
||
Please write a summary of your changes and why you made them. | ||
|
||
## Links to any relevant issues | ||
|
||
Be sure to reference any related issues by adding `fixes #(issue)`. | ||
|
||
## Type of change | ||
|
||
Choose a type of change, and delete any options that are not relevant. | ||
|
||
- Bug fix (a non-breaking change which fixes an issue) | ||
- Enhancement (a non-breaking change which adds functionality) | ||
- Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
- Documentation Fix | ||
|
||
## How the change has been tested | ||
|
||
Describe the tests that you ran to verify your changes. | ||
|
||
Make sure to provide instructions for the maintainer as well as any relevant configurations. | ||
|
||
- [ ] Basic tests (linting, compilation, formatting, unit/integration tests) | ||
- [ ] Patch-specific tests (correctness, functionality coverage) | ||
|
||
### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) | ||
|
||
- [ ] Synchronization of the indexer from genesis for a network including migration objects. | ||
- [ ] Restart of indexer synchronization locally without resetting the database. | ||
- [ ] Restart of indexer synchronization on a production-like database. | ||
- [ ] Deployment of services using Docker. | ||
- [ ] Verification of API backward compatibility. | ||
|
||
## Change checklist | ||
|
||
Tick the boxes that are relevant to your changes, and delete any items that are not. | ||
|
||
- [ ] I have followed the contribution guidelines for this project | ||
- [ ] I have performed a self-review of my own code | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have made corresponding changes to the documentation | ||
- [ ] I have added tests that prove my fix is effective or that my feature works | ||
- [ ] I have checked that new and existing unit tests pass locally with my changes | ||
|
||
### Release Notes | ||
|
||
<!-- | ||
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. | ||
|
||
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. | ||
--> | ||
|
||
- [ ] Protocol: | ||
- [ ] Nodes (Validators and Full nodes): | ||
- [ ] Indexer: | ||
- [ ] JSON-RPC: | ||
- [ ] GraphQL: | ||
- [ ] CLI: | ||
- [ ] Rust SDK: | ||
- [ ] REST API: | ||
- [Default PR Template for External Contributors](?expand=1&template=default_external_contributors.md) | ||
- [Default PR Template for Internal Contributors](?expand=1&template=default_internal_contributors.md) | ||
- [Infrastructure Team](?expand=1&template=infra.md) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't need to mention that it's for infra only in here anymore right?