Bring upstream latest changes#2
Closed
hect95 wants to merge 79 commits intoinit_sensor_calibrationfrom
Closed
Conversation
updates: - [github.com/pre-commit/mirrors-clang-format: v18.1.5 → v18.1.7](pre-commit/mirrors-clang-format@v18.1.5...v18.1.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/tier4/pre-commit-hooks-ros: v0.8.0 → v0.10.0](tier4/pre-commit-hooks-ros@v0.8.0...v0.10.0) - [github.com/pre-commit/mirrors-clang-format: v18.1.7 → v18.1.8](pre-commit/mirrors-clang-format@v18.1.7...v18.1.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/scop/pre-commit-shfmt: v3.8.0-1 → v3.9.0-1](scop/pre-commit-shfmt@v3.8.0-1...v3.9.0-1) - [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* chore: changed the folder structure following the removal of non sensor related packages Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * add indefinite article Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix camera info explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix kalman filter Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix sentence Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix capital Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix more sentence Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix description Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix background model Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add more explaination for marker package Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix lidartag, apriltag Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fixed camera_info Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix Final TF tree description Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix plural Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add more explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * grammar fix Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix sentence Signed-off-by: vividf <yihsiang.fang@tier4.jp> * clarify some sentences Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix sentence Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * fix related link Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add more explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add more explanation to marker docs and tutorial Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add more explanation for mapping based docs and tutorial Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix some previous error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix section Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * fix word Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix from True to true Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add correct unit Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix radar description Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix topic description Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add addtional line Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix service description Signed-off-by: vividf <yihsiang.fang@tier4.jp> * seperate text in step4 Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix background model timeout description Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix min_foreground_points Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix sentence Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add explanation for radar foreground figure Signed-off-by: vividf <yihsiang.fang@tier4.jp> * change to plural Signed-off-by: vividf <yihsiang.fang@tier4.jp> * lidar cluster and blue points explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add radar resolution limitation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix pro tips Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix known limitation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix initial calibration error explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add BEV enviroment Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add vis image for mapping based Signed-off-by: vividf <yihsiang.fang@tier4.jp> * change to svg file Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix errors Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add resolution explaination Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix lidar to camera Signed-off-by: vividf <yihsiang.fang@tier4.jp> * remove last point Signed-off-by: vividf <yihsiang.fang@tier4.jp> * seperate the context Signed-off-by: vividf <yihsiang.fang@tier4.jp> * remove accurately Signed-off-by: vividf <yihsiang.fang@tier4.jp> * remove addtional the Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add link Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix message to object and add reason of reliably detecting challenge Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix section 2 Signed-off-by: vividf <yihsiang.fang@tier4.jp> * improve step 3 Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix calibration camera Signed-off-by: vividf <yihsiang.fang@tier4.jp> * add docker solution Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix some sentences in mapping_based Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix the input parameters Signed-off-by: vividf <yihsiang.fang@tier4.jp> * ci(pre-commit): autofix * chore: applied changes from the auto messages migration note: this was note made as another PR since it also involved documentation Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: mispells Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: another attempt to fix the mispell Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: forgot to commit one .repos file Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: replaced private links for public ones Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: fix input Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix the FAQ Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix radar purpose Signed-off-by: vividf <yihsiang.fang@tier4.jp> * predict to estimate Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix radar vis image Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix foreground extraction Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix radar step 3 explaination Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix add_lidar_radar_pair parameter explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix radar Pro tips/recommendations Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix radar foreground pointcloud Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: replace the pnp lidar pos to correct one Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix didn't to did not Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix tag pos explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove some text Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix some sentence of mapping Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add radar foreground and background image and explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix parameter desciption Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix larger to exceed Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grammar errors in mapping based calibrator Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grammar errors in marker based calibrator Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fixed ci/cd Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: ci/cd part 2 Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: moved meta package's path Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: changed private repo to oss one Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: Update calibrators/marker_radar_lidar_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * chore: fix marker calibrator algorithms explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add calibration process Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove first Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grammar Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove finalize Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix Z to z Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: specify yaw rotation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix all of the explanation for output parameters Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change predictable Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove redundant calibration area Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix pro tips Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change to calibrating Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix more grammar errors Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add more info for the radar foreground image Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add explanation for estimation algorithm Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add svd explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix radar reflector explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove while Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove angle Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix mapping errors Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: update calibrators/marker_radar_lidar_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * chore: fix grammar Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix radar pro tips Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: update calibrators/tag_based_pnp_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * chore: add pnp known issues Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grammar error, pnp overall calibration env Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grammar error: that Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix pnp FAQ Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add the Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: reflectors's tracks Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: build to mount Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix final step Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add comma Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fix radar foreground points to object Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove that is Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix denote as Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add explanation for step 4 Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix services Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix radar parallel frame Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix transformation type Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add unit1 Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add unit2 Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: no reflector, person, ... Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: imperfect to inaccuarate Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix object_raw Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix and to or Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix show like sentence Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix link, not in comment Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add explanation for radar foreground Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix add lidar-radar pair Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix blue point explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: explain two radar , one lidar Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: line to curve Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change coordinate to frame Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add explanation for ground segmentation in radar-lidar calibrator Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add ground segmentation model Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fixed compilations issues due to changes in universe Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: colcon ignored the tunable tf package since it produces build errors and is not being maintained Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: attepting to update ci/cd since it seemed old and it was failing Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: removed galactic from ci/cd since it is unsupported and was still part of our ci/cd Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: fixed missing cpell ignores Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: fix mapping calibrator Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fix spell check Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fix grammar errors Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fix mapping section Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fix errors Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fix grammar error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fix parameters spell check Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove the redundant line Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix central to center Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add between sensors Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grids to grid Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix transformation type explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix rigid transformation estimation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add additional explanation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove processes Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change pinpoint to estiamte Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix topic name Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix doesn't to does not Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add more explanation to radar parallel frame Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix topic Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: unify radar parallel frame and clarify z component Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update calibrators/docs/tutorials/marker_radar_lidar_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/marker_radar_lidar_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * chore: fix grammar error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix at which Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add in seconds unit Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix max_no_observation_time Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix new_hypothesis_distance Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix to degrees Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix all square issues Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix lowercase Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: ARS408 radars Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add missing the Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix input_lidar_pointcloud Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix layout Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix more layout Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix sentences Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix in rviz Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grammar error: of Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: move butoon out Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: radar_foreground_pointcloud Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove quotation marks Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fix mapping based Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix more grammar error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update calibrators/marker_radar_lidar_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * chore: fix all rviz Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix unit Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix detections Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix ARS Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix like below Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix uppercase Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix context in mapping Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove some text Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix some grammar Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update calibrators/mapping_based_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/mapping_based_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/mapping_based_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * chore: fix spell error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update calibrators/mapping_based_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * chore: fix link Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix known issues grammar Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: known issues grammar error2 Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: tips for distortion Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix all base_link Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix step 2 Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: dense_pointcloud_num_keyframes plural fix Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: for developers Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: keyframe markers and the Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: extracted from Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove () Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add pro-tips Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix step 2 calibration data preparation Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add processing Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix data selection Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix more data selection Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: would be to identical Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: could get to obtain Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix: fixed dependencies (due to autoware's autoware prefix) Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: moved the sensor calibrator manager outside of the calibrators folder (other changes are pre-commit induced) Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: updated the use of the kalman filter implementation since it was moved into the autoware namespace Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * fix: updated the use of the decompressor Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: adapted to the new way of using lidartag Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * fix: init tf tree visualization (tier4#188) * fix: init tf tree visualization Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix error Signed-off-by: vividf <yihsiang.fang@tier4.jp> --------- Signed-off-by: vividf <yihsiang.fang@tier4.jp> * fix(intrinsic_camera_calibrator): fixed dot board detector (tier4#189) fix: forgot to add a fix to the dot board detector Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * docs: candidate for the final documentation of the new api Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: fixed dead links and spelling Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: fixed missing mispell in a package name Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: fixed missing dead link Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Signed-off-by: vividf <yihsiang.fang@tier4.jp> Co-authored-by: vividf <yihsiang.fang@tier4.jp> Co-authored-by: Yi-Hsiang Fang (Vivid) <146902905+vividf@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/igorshubovych/markdownlint-cli: v0.41.0 → v0.42.0](igorshubovych/markdownlint-cli@v0.41.0...v0.42.0) - [github.com/pre-commit/mirrors-clang-format: v18.1.8 → v19.1.0](pre-commit/mirrors-clang-format@v18.1.8...v19.1.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0) - [github.com/pre-commit/mirrors-clang-format: v19.1.0 → v19.1.1](pre-commit/mirrors-clang-format@v19.1.0...v19.1.1) - [github.com/cpplint/cpplint: 1.6.1 → 2.0.0](cpplint/cpplint@1.6.1...2.0.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* chore: fixed the pre-commit issues discovered in tier4#201 Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: added more fixes that were reported after the last one Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: a few more pre-commit error fixes Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…ator (tier4#141) * Implemented a ceres-based camera intrinsics calibrator. Numerical results seem to be the same as opencv but it is way faster when using a large number of calibration images Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * Removed unused file Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * refactor(ceres_intrinsic_camera_calibrator): new directory structure Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp> * chore(ceres_intrinsic_camera_calibrator): update dependencies Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp> * chore(ceres_intrinsic_camera_calibrator): install targets Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp> * chore: updated headers, addressed pre-commit concerns, and fixed some data conditions Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * feat: backported the rational model implementation and other changes (was lost in an experimental branch) Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: ci/cd fixes Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: last ci/cd fixes Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: last-last fix Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * fix(intrinsic_camera_calibrator): empty points array Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp> * fix(ceres_intrinsic_camera_calibrator): missing args & args order Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp> * feat(ceres_intrinsic_camera_calibrator): enable rational coeffs Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp> * ci(pre-commit): autofix * chore: updated parameter check Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: type fix Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp> Co-authored-by: amadeuszsz <amadeusz.szymko.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix: attempted to address non freed memory Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: deleted an unused method Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: typos Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
updates: - [github.com/scop/pre-commit-shfmt: v3.9.0-1 → v3.10.0-1](scop/pre-commit-shfmt@v3.9.0-1...v3.10.0-1) - [github.com/pre-commit/mirrors-clang-format: v19.1.1 → v19.1.3](pre-commit/mirrors-clang-format@v19.1.1...v19.1.3) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…g outputed (tier4#207) fix: the board poses were not being outputed Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…ls & ceres integration Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
…ation settings Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
…calibration for Ceres Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
…er4#211) fix: typo in the lidar-lidar calibrator Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
… Ceres Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
…logging Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
…tion samples for Ceres calibrator Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
…calibrator-integration feat(intrinsic_camera_calibrator): multiple camera models & ceres integration
updates: - [github.com/igorshubovych/markdownlint-cli: v0.42.0 → v0.43.0](igorshubovych/markdownlint-cli@v0.42.0...v0.43.0) - [github.com/pre-commit/mirrors-clang-format: v19.1.3 → v19.1.4](pre-commit/mirrors-clang-format@v19.1.3...v19.1.4) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…insic & correct function names (tier4#217) Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
…tomatically (tier4#222) faet: changed sqpnp to the best between sqpnp and the iterative for pnp based calibration. automatically choose between observations and hypotheses when returning the final calibration Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
updates: - [github.com/scop/pre-commit-shfmt: v3.10.0-1 → v3.10.0-2](scop/pre-commit-shfmt@v3.10.0-1...v3.10.0-2) - [github.com/pre-commit/mirrors-clang-format: v19.1.4 → v19.1.5](pre-commit/mirrors-clang-format@v19.1.4...v19.1.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix: removed unnecessary dependencies Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: we actually needed opencv Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * fix: deleted boost from the cmakelist Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
updates: - [github.com/pre-commit/mirrors-clang-format: v19.1.5 → v19.1.6](pre-commit/mirrors-clang-format@v19.1.5...v19.1.6) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ilename (tier4#224) docs: update README to correct calibration tools repository filename Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
…iles (tier4#220) * [fix] speed filter option wrong type, added params to config camera calibration file * [wip] functions to get training coverage percentage for skew, board size * [New] added UI indicators for speed, skew and size coverage of the board * [wip] Added Linear error rows/cols indicator * [wip] manually fix problem loading intrinsics file, enabling disabling elements for eval mode * [New] Added percentage linear error indicator rows cols * [New] Aspect ratio measurement and heatmap for linearity added * [New]Clear linearity hetmap, aspect ratio, board angles, save points and calibration parameters into a file, change ui elements in eval mode. * ci(pre-commit): autofix * [wip] Adding menu to load profile parameters * Fixing Typo errors an formatting * [Fix] Fixing more typo errors and spelling * [Fix] disabling cspell for one line to pass check * [Fix] Removing capital from boolean yaml values because yamllint failure * Disabling rule:truthy for yamllint check * fix: solved runtime errors but disabled some features Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * [wip] menu to load 3 camera parameters profile * [fix] eval mode working with new ceres solver, aspect ratio working * [New] Added set_parameters fcn to chessboard detection, params added to yaml files * [fix] fixed mistake on the previous commit when adding files * ci(pre-commit): autofix * refactor: first changes according to the PR comments * ci(pre-commit): autofix * refactor: all comments form the discussion were addressed here * ci(pre-commit): autofix * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/views/image_view.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/views/image_view.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py accepting suggestion Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * fix: correcting misspelled * refactor: fixing some spelling errors * refactor: change parameters file for c2 camera --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
updates: - [github.com/igorshubovych/markdownlint-cli: v0.43.0 → v0.44.0](igorshubovych/markdownlint-cli@v0.43.0...v0.44.0) - [github.com/pre-commit/mirrors-clang-format: v19.1.6 → v19.1.7](pre-commit/mirrors-clang-format@v19.1.6...v19.1.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…r4#226) * feat(ceres_intrinsic_camera_calibrator): set threshold for clamping residuals Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat(ceres_intrinsic_camera_calibrator): remove threshold & use log function for residuals Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat(intrinsic_camera_calibrator): logging Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat(ceres_intrinsic_camera_calibrator): ignore regularization for 0.0 weight Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> --------- Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
chore: added core into the .repos since the kalman filter was moved Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
updates: - [github.com/pycqa/isort: 5.13.2 → 6.0.0](PyCQA/isort@5.13.2...6.0.0) - [github.com/psf/black: 24.10.0 → 25.1.0](psf/black@24.10.0...25.1.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…4#228) * feat(ceres_intrinsic_camera_calibrator): add FOV regularization Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat(ceres_intrinsic_camera_calibrator): use approximation for undistortion and distortion Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * style(ceres_intrinsic_camera_calibrator): cSpell Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * style(ceres_intrinsic_camera_calibrator): sync with Gregorian calendar Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * fix(ceres_intrinsic_camera_calibrator): remove unused headers Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * fix(ceres_intrinsic_camera_calibrator): remove cond statement for coeffs regularization block Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * fix(ceres_intrinsic_camera_calibrator): casting consistency for T Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat(ceres_intrinsic_camera_calibrator): apply FOV regularization out of main optimization graph Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat(ceres_intrinsic_camera_calibrator): apply FOV regularization only if anomaly detected Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * fix(ceres_intrinsic_camera_calibrator): function naming Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat(ceres_intrinsic_camera_calibrator): improve logging Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * style(ceres_intrinsic_camera_calibrator): pass args Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * fix(ceres_intrinsic_camera_calibrator): use ceres min and max Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * ci(pre-commit): autofix * style(ceres_intrinsic_camera_calibrator): var naming for array indices Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat(ceres_intrinsic_camera_calibrator): expand fov residuals dimension Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * style(ceres_intrinsic_camera_calibrator): unnecessary commented lines Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> --------- Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/pycqa/isort: 6.0.0 → 6.0.1](PyCQA/isort@6.0.0...6.0.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/scop/pre-commit-shfmt: v3.10.0-2 → v3.11.0-1](scop/pre-commit-shfmt@v3.10.0-2...v3.11.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
* ci(pre-commit): autoupdate updates: - [github.com/adrienverge/yamllint: v1.35.1 → v1.37.0](adrienverge/yamllint@v1.35.1...v1.37.0) - [github.com/pre-commit/mirrors-clang-format: v19.1.7 → v20.1.0](pre-commit/mirrors-clang-format@v19.1.7...v20.1.0) * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…er4#240) * fix:mapping_based_lidar_lidar_calibrator result dictionary typo * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
* [fix] speed filter option wrong type, added params to config camera calibration file * [wip] functions to get training coverage percentage for skew, board size * [New] added UI indicators for speed, skew and size coverage of the board * [wip] Added Linear error rows/cols indicator * [wip] manually fix problem loading intrinsics file, enabling disabling elements for eval mode * [New] Added percentage linear error indicator rows cols * [New] Aspect ratio measurement and heatmap for linearity added * [New]Clear linearity hetmap, aspect ratio, board angles, save points and calibration parameters into a file, change ui elements in eval mode. * ci(pre-commit): autofix * [wip] Adding menu to load profile parameters * Fixing Typo errors an formatting * [Fix] Fixing more typo errors and spelling * [Fix] disabling cspell for one line to pass check * [Fix] Removing capital from boolean yaml values because yamllint failure * Disabling rule:truthy for yamllint check * fix: solved runtime errors but disabled some features Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * [wip] menu to load 3 camera parameters profile * [fix] eval mode working with new ceres solver, aspect ratio working * [New] Added set_parameters fcn to chessboard detection, params added to yaml files * [fix] fixed mistake on the previous commit when adding files * ci(pre-commit): autofix * [wip] using roi and skip frames to improve performance * [wip] forcing resize mode * [wip] removed change auto to resize mode tested on Anvil * [fix] not used variable was causing a failure * refactor: first changes according to the PR comments * ci(pre-commit): autofix * refactor: all comments form the discussion were addressed here * ci(pre-commit): autofix * wip: debugging k, d and some other params * fix: change precision of the data when saving intrinsic parameters, solve problems when rectifying * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/views/image_view.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/views/image_view.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py accepting suggestion Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * fix: correcting misspelled * refactor: cleaning a bit the code and fixing some lines of code * feat: Added new rectification to fix aspect ratio and skip images option * refactor: fixing some spelling errors * feat: change distortion model according to the number of distortion elements * refactor: change params calibration files * [wip] debugging segmentation fault using debugpy * fix: pause state due unhandled subpixel refinement exception, preventing signal return * refactor deleting comments * refactor: modifying default calibration parameters * ci(pre-commit): autofix * refactor: changing comment style * ci(pre-commit): autofix * refactor: removing spaces * refactor: removing bank spaces * refactor: returning original c1 params for reprojection error * refactor: making normal variables as parameter * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/camera_calibrator.py Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/camera_models/camera_model.py Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * ci(pre-commit): autofix * refactor: adding mutex to variable access * ci(pre-commit): autofix * refactor: adding blank space and changing decimal precision when saving parameters * refactor: adding parameter for number of frames to skip * ci(pre-commit): autofix * refactor: adding enum for rectification options * ci(pre-commit): autofix * refactor: cached model restarts inside class * ci(pre-commit): autofix * refactor: adding exclusion to cspell and blank space * refactor: small refactor fot detect function * ci(pre-commit): autofix * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update calibrators/intrinsic_camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/utils.py Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * ci(pre-commit): autofix * refactor: small refactor and protecting value --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
updates: - [github.com/cpplint/cpplint: 2.0.0 → 2.0.1](cpplint/cpplint@2.0.0...2.0.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ation_msgs (tier4#246) chore: renames tier4_calibration_msgs to tier4_sensor_calibration_msgs since there was already a tier4_calibration_msgs in another related repo Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
updates: - [github.com/cpplint/cpplint: 2.0.1 → 2.0.2](cpplint/cpplint@2.0.1...2.0.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.