Merged
Conversation
- Allow continuing the dataset creation if any sequence's trajectory pose count and lidar keyframes differ. - Define a new error type `InvalidPoseCountError` in `response.py` to distinguish this case from segments errors. - Update `SegmentsSampleCreator.add()` method in `add_segmentsai_sample.py` to prevent continuing with the sample creation if this error is raised and return an appropriate response. - Update `DatasetCreator.create()` in `dataset_creator.py` to track how and which sequences were skipped and log it after processing all sequences.
- Install `tartan_rosbag_exporter` version 2.0.0. to support
new hesai lidars pointcloud export.
- Update `av_sensor_export_config.yaml` to add `timestamp_offset_ms`
parameter for each camera.
- Update `sample_formats.py` to include `fsp_r` and `rsp_r` cameras.
- Defining a new 2x4 grid visualisation layout for the new cameras
in Segments.ai.
- Update `sensor_frame_creator.py` to use `lidar_top` as
`self.LIDAR_FRAME_ID` instead of `lidar_ouster_top`.
- Sort labels in alphabetical order
hect95
changed the title
hect95
changed the title
- Define default parameters values for both `dataset_manager.py` and `dataset_creator.py` to simplify their use. Assume the scripts are lunched inside the docker container.
- Tune parameters to reduce MOLA Odometry skiping top lidar pointclouds
- Make `/mnt/sata_ssd_raid/edinburgh` the default directory to search for rosbags to upload - Make `/mnt/vdb/data` the default EIDF's directory to save upoaded rosbags
- Add `--logs_directory` argument in `data_manager` and define `/opt/ros_ws/logs_tartan_forklfit` as default
hect95
commented
Aug 12, 2025
- Ignore mcap files located inside compression temporary directory
- Allow to resume uploads without removing the
temporary directory manually
- Display an image showing the Data pipeline system diagram - Re-structure the file so the Usage guide on how to run the pipeline appears first
GreatAlexander
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tartan_rosbag_exporterversion 2.0.0. to supportnew Hesai lidars pointcloud export.
av_sensor_export_config.yamlto addtimestamp_offset_msparameter for each camera.
sample_formats.pyto includefsp_randrsp_rcameras.in Segments.ai.
sensor_frame_creator.pyto uselidar_topasself.LIDAR_FRAME_IDinstead oflidar_ouster_top.dataset_attributes.jsonfiletrajectory pose count and lidar keyframes differ.
InvalidPoseCountErrorinresponse.pytodistinguish this case from Segments.ai errors.
SegmentsSampleCreator.add()method inadd_segmentsai_sample.pyto prevent continuing with the samplecreation if this error is raised, and return an appropriate response.
DatasetCreator.create()indataset_creator.pyto trackhow and which sequences were skipped and log it after processing
all sequences
appears first